From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934520AbcKDOW2 (ORCPT ); Fri, 4 Nov 2016 10:22:28 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35978 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755812AbcKDOWZ (ORCPT ); Fri, 4 Nov 2016 10:22:25 -0400 Date: Fri, 4 Nov 2016 15:22:19 +0100 From: Heiko Carstens To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, rt@linutronix.de, Thomas Gleixner , Martin Schwidefsky , linux-s390@vger.kernel.org Subject: Re: [PATCH 10/25] s390/smp: Make cpu notifier symetric References: <20161103145021.28528-1-bigeasy@linutronix.de> <20161103145021.28528-11-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161103145021.28528-11-bigeasy@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16110414-0012-0000-0000-00000480A2F4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16110414-0013-0000-0000-00001610BB2B Message-Id: <20161104142219.GC4088@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-04_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611040271 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 03, 2016 at 03:50:06PM +0100, Sebastian Andrzej Siewior wrote: > From: Thomas Gleixner > > There is no reason to remove the sysfs cpu files when the CPU is dead, they > can be removed when the cpu is prepared to go down. Doing it at > DOWN_PREPARE allows us to convert it to a symetric hotplug state in the > next step. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-s390@vger.kernel.org > Signed-off-by: Thomas Gleixner > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/s390/kernel/smp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c > index 35531fe1c5ea..1a21e66c484a 100644 > --- a/arch/s390/kernel/smp.c > +++ b/arch/s390/kernel/smp.c > @@ -1056,9 +1056,10 @@ static int smp_cpu_notify(struct notifier_block *self, unsigned long action, > > switch (action & ~CPU_TASKS_FROZEN) { > case CPU_ONLINE: > + case CPU_DOWN_FAILED: > err = sysfs_create_group(&s->kobj, &cpu_online_attr_group); > break; > - case CPU_DEAD: > + case CPU_DOWN_PREPARE:: This won't compile... even though it will be removed with the following patch it would be good to fix this to keep this bisectable.