From: Darren Hart <dvhart@infradead.org>
To: Anthony Wong <ypwong@gmail.com>
Cc: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, "Lee, Chun-Yi" <jlee@suse.com>
Subject: Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family
Date: Sat, 5 Nov 2016 11:27:20 -0700 [thread overview]
Message-ID: <20161105182720.GC100528@f23x64.localdomain> (raw)
In-Reply-To: <CAE7LaDAmQjjToC8n6mLNM8dJf1Vm4QN7wu7-Hk8=dwRp2XyfsA@mail.gmail.com>
On Thu, Nov 03, 2016 at 11:40:15AM +0800, Anthony Wong wrote:
> On 1 November 2016 at 12:30, Lee, Chun-Yi <joeyli.kernel@gmail.com> wrote:
> >
> > The AMW0_GUID1 wmi is not only found on Acer family but also other
> > machines like Lenovo, Fujitsu and Medion. In the past days, acer-wmi
> > driver handled those non-Acer machines by quirks list.
> >
> > But actually acer-wmi driver was loaded on any machines that have
> > AMW0_GUID1. This behavior is strange because those machines should
> > be supported by appropriate wmi drivers. e.g. fujitsu-laptop,
> > ideapad-laptop.
> >
> > So, This patch adds the logic to check the machine that has AMW0_GUID1
> > should be in Acer/Packard Bell/Gateway white list. But, it still keeps
> > the quirk list of those supported non-acer machines for backward
> > compatible.
> >
> > Tested-by: Bjørn Mork <bjorn@mork.no>
> > Cc: Darren Hart <dvhart@infradead.org>
> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
>
> Xiaomi Air 13.3 notebook suffers from the same issue, acer-wmi
> basically has no use on this machine. With your patch, acer-wmi no
> longer loads.
>
> Tested-by: Anthony Wong <anthony@ypwong.org>
I've already pushed this to -next, but thank you for the confirmation.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-11-05 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 4:30 [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family Lee, Chun-Yi
2016-11-03 3:40 ` Anthony Wong
2016-11-03 4:14 ` joeyli
2016-11-05 18:27 ` Darren Hart [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-12 23:32 Lee, Chun-Yi
2016-08-29 9:55 Lee, Chun-Yi
2016-08-29 10:11 ` Bjørn Mork
2016-08-29 12:55 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161105182720.GC100528@f23x64.localdomain \
--to=dvhart@infradead.org \
--cc=jlee@suse.com \
--cc=joeyli.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ypwong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox