From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751382AbcKFEDe (ORCPT <rfc822;w@1wt.eu>);
        Sun, 6 Nov 2016 00:03:34 -0400
Received: from mail.kernel.org ([198.145.29.136]:59536 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751008AbcKFEDe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 6 Nov 2016 00:03:34 -0400
Date: Sat, 5 Nov 2016 22:03:30 -0600
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Eric Engestrom <eric.engestrom@imgtec.com>,
        He Kuang <hekuang@huawei.com>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf thread: cleanup with list_first_entry_or_null()
Message-ID: <20161106040330.GA12125@kernel.org>
References: <1473704975-4636-1-git-send-email-yamada.masahiro@socionext.com>
 <CAK7LNATFxF4=nWzO69aNqUkRdeGAyom0Q6k0S+OeKFA2v+fkew@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNATFxF4=nWzO69aNqUkRdeGAyom0Q6k0S+OeKFA2v+fkew@mail.gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Sun, Nov 06, 2016 at 12:00:22PM +0900, Masahiro Yamada escreveu:
> Hi maintainers,
> 
> Does this patch look good?

>>From a quick look it seems ok, I'll try and process it when back home.

- Arnaldo
 
> 2016-09-13 3:29 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > The combo of list_empty() check and return list_first_entry()
> > can be replaced with list_first_entry_or_null().
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> >  tools/perf/util/thread.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
> > index 8b10a55..ea951df 100644
> > --- a/tools/perf/util/thread.c
> > +++ b/tools/perf/util/thread.c
> > @@ -107,10 +107,7 @@ void thread__put(struct thread *thread)
> >
> >  struct comm *thread__comm(const struct thread *thread)
> >  {
> > -       if (list_empty(&thread->comm_list))
> > -               return NULL;
> > -
> > -       return list_first_entry(&thread->comm_list, struct comm, list);
> > +       return list_first_entry_or_null(&thread->comm_list, struct comm, list);
> >  }
> >
> >  struct comm *thread__exec_comm(const struct thread *thread)
> > --
> > 1.9.1
> >
> 
> 
> 
> -- 
> Best Regards
> Masahiro Yamada