From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499AbcKFRtE (ORCPT ); Sun, 6 Nov 2016 12:49:04 -0500 Received: from up.free-electrons.com ([163.172.77.33]:60289 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750927AbcKFRtD (ORCPT ); Sun, 6 Nov 2016 12:49:03 -0500 Date: Sun, 6 Nov 2016 18:49:00 +0100 From: Boris Brezillon To: Zach Brown Cc: , , , , , Subject: Re: [PATCH v4 3/5] mtd: nand: Add bb_per_die and blocks_per_die fields to nand_chip Message-ID: <20161106184900.1c937981@bbrezillon> In-Reply-To: <1478024190-13713-4-git-send-email-zach.brown@ni.com> References: <1478024190-13713-1-git-send-email-zach.brown@ni.com> <1478024190-13713-4-git-send-email-zach.brown@ni.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Nov 2016 13:16:28 -0500 Zach Brown wrote: > The fields bb_per_die and blocks_per_die are useful determining the > number of bad blocks a MTD needs to allocate. How they are set will > depend on if the chip is ONFI, JEDEC or a full-id entry in the nand_ids > table. > > Signed-off-by: Zach Brown > --- > include/linux/mtd/nand.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > index d8905a2..3093827 100644 > --- a/include/linux/mtd/nand.h > +++ b/include/linux/mtd/nand.h > @@ -771,6 +771,9 @@ nand_get_sdr_timings(const struct nand_data_interface *conf) > * supported, 0 otherwise. > * @jedec_params: [INTERN] holds the JEDEC parameter page when JEDEC is > * supported, 0 otherwise. > + * @bb_per_die: [INTERN] the max number of bad blocks each die of a > + * this nand device will encounter their life times. > + * @blocks_per_die: [INTERN] The number of PEBs in a die > * @read_retries: [INTERN] the number of read retry modes supported > * @onfi_set_features: [REPLACEABLE] set the features for ONFI nand > * @onfi_get_features: [REPLACEABLE] get the features for ONFI nand > @@ -853,6 +856,8 @@ struct nand_chip { > struct nand_onfi_params onfi_params; > struct nand_jedec_params jedec_params; > }; > + u16 bb_per_die; Why not max_bb_per_die? And please put a single space between the type and the field name. > + u32 blocks_per_die; > > struct nand_data_interface *data_interface; >