From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org,
Sascha Silbe <silbe@linux.vnet.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c
Date: Mon, 7 Nov 2016 08:03:22 +0100 [thread overview]
Message-ID: <20161107070322.GA4075@osiris> (raw)
In-Reply-To: <1478403928-20799-2-git-send-email-yamada.masahiro@socionext.com>
On Sun, Nov 06, 2016 at 12:45:28PM +0900, Masahiro Yamada wrote:
> We generally expect headers in arch/$(ARCH)/include/asm directory
> are included from kernel sources, but facilities_src.h is not;
> it is included from the arch/s390/tools/gen_facilities.c tool.
>
> There is no reason to expose this header to the public include path.
> Furthermore, facilities_src.h makes sure to be included only from
> gen_facilities.c by the following:
>
> #ifndef S390_GEN_FACILITIES_C
> #error "This file can only be included by gen_facilities.c"
> #endif
>
> This check can be removed by merging the two files.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Both patches:
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Martin, can you please pick them up?
next prev parent reply other threads:[~2016-11-07 7:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 3:45 [PATCH 1/2] s390: delete unneeded #include <linux/kconfig.h> from facilities_src.h Masahiro Yamada
2016-11-06 3:45 ` [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c Masahiro Yamada
2016-11-07 7:03 ` Heiko Carstens [this message]
2016-11-07 9:50 ` Martin Schwidefsky
2016-11-07 13:13 ` Paul Bolle
2016-11-07 13:38 ` Heiko Carstens
2016-11-08 9:18 ` Paul Bolle
2016-11-07 12:52 ` [PATCH 1/2] s390: delete unneeded #include <linux/kconfig.h> from facilities_src.h Paul Bolle
2016-11-08 1:50 ` Masahiro Yamada
2016-11-08 9:16 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107070322.GA4075@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=silbe@linux.vnet.ibm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox