From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752889AbcKGLqd (ORCPT ); Mon, 7 Nov 2016 06:46:33 -0500 Received: from bastet.se.axis.com ([195.60.68.11]:56661 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbcKGLqb (ORCPT ); Mon, 7 Nov 2016 06:46:31 -0500 Date: Mon, 7 Nov 2016 12:46:28 +0100 From: Jesper Nilsson To: Guenter Roeck Cc: Mikael Starvik , Jesper Nilsson , linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cris: Only build flash rescue image if CONFIG_ETRAX_AXISFLASHMAP is selected Message-ID: <20161107114628.GS30704@axis.com> References: <1477843758-23609-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477843758-23609-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 30, 2016 at 09:09:18AM -0700, Guenter Roeck wrote: > If CONFIG_ETRAX_AXISFLASHMAP is not configured, the flash rescue image > object file is empty. With recent versions of binutils, this results > in the following build error. > > cris-linux-objcopy: error: > the input file 'arch/cris/boot/rescue/rescue.o' has no sections > > This is seen, for example, when trying to build cris:allnoconfig > with recently generated toolchains. > > Since it does not make sense to build a flash rescue image if there is > no flash, only build it if CONFIG_ETRAX_AXISFLASHMAP is enabled. Agreed, added to cris tree for 4.10. > Reported-by: kbuild test robot > Fixes: 66ab3a74c5ce ("CRIS: Merge machine dependent boot/compressed ..") > Signed-off-by: Guenter Roeck Thanks! /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com