* [PATCH] cris: Only build flash rescue image if CONFIG_ETRAX_AXISFLASHMAP is selected
@ 2016-10-30 16:09 Guenter Roeck
2016-11-07 11:46 ` Jesper Nilsson
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2016-10-30 16:09 UTC (permalink / raw)
To: Mikael Starvik
Cc: Jesper Nilsson, linux-cris-kernel, linux-kernel, Guenter Roeck
If CONFIG_ETRAX_AXISFLASHMAP is not configured, the flash rescue image
object file is empty. With recent versions of binutils, this results
in the following build error.
cris-linux-objcopy: error:
the input file 'arch/cris/boot/rescue/rescue.o' has no sections
This is seen, for example, when trying to build cris:allnoconfig
with recently generated toolchains.
Since it does not make sense to build a flash rescue image if there is
no flash, only build it if CONFIG_ETRAX_AXISFLASHMAP is enabled.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 66ab3a74c5ce ("CRIS: Merge machine dependent boot/compressed ..")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/cris/boot/rescue/Makefile | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/cris/boot/rescue/Makefile b/arch/cris/boot/rescue/Makefile
index 52bd0bd1dd22..d98edbb30a18 100644
--- a/arch/cris/boot/rescue/Makefile
+++ b/arch/cris/boot/rescue/Makefile
@@ -10,6 +10,9 @@
asflags-y += $(LINUXINCLUDE)
ccflags-y += -O2 $(LINUXINCLUDE)
+
+ifdef CONFIG_ETRAX_AXISFLASHMAP
+
arch-$(CONFIG_ETRAX_ARCH_V10) = v10
arch-$(CONFIG_ETRAX_ARCH_V32) = v32
@@ -28,6 +31,11 @@ $(obj)/rescue.bin: $(obj)/rescue.o FORCE
$(call if_changed,objcopy)
cp -p $(obj)/rescue.bin $(objtree)
+else
+$(obj)/rescue.bin:
+
+endif
+
$(obj)/testrescue.bin: $(obj)/testrescue.o
$(OBJCOPY) $(OBJCOPYFLAGS) $(obj)/testrescue.o tr.bin
# Pad it to 784 bytes
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] cris: Only build flash rescue image if CONFIG_ETRAX_AXISFLASHMAP is selected
2016-10-30 16:09 [PATCH] cris: Only build flash rescue image if CONFIG_ETRAX_AXISFLASHMAP is selected Guenter Roeck
@ 2016-11-07 11:46 ` Jesper Nilsson
0 siblings, 0 replies; 2+ messages in thread
From: Jesper Nilsson @ 2016-11-07 11:46 UTC (permalink / raw)
To: Guenter Roeck
Cc: Mikael Starvik, Jesper Nilsson, linux-cris-kernel, linux-kernel
On Sun, Oct 30, 2016 at 09:09:18AM -0700, Guenter Roeck wrote:
> If CONFIG_ETRAX_AXISFLASHMAP is not configured, the flash rescue image
> object file is empty. With recent versions of binutils, this results
> in the following build error.
>
> cris-linux-objcopy: error:
> the input file 'arch/cris/boot/rescue/rescue.o' has no sections
>
> This is seen, for example, when trying to build cris:allnoconfig
> with recently generated toolchains.
>
> Since it does not make sense to build a flash rescue image if there is
> no flash, only build it if CONFIG_ETRAX_AXISFLASHMAP is enabled.
Agreed, added to cris tree for 4.10.
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 66ab3a74c5ce ("CRIS: Merge machine dependent boot/compressed ..")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Thanks!
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-07 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-30 16:09 [PATCH] cris: Only build flash rescue image if CONFIG_ETRAX_AXISFLASHMAP is selected Guenter Roeck
2016-11-07 11:46 ` Jesper Nilsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).