From: Eugene Korenevsky <ekorenevsky@gmail.com>
To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luiz Capitulino <lcapitulino@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Chase Metzger <chasemetzger15@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Oliver Neukum <oneukum@suse.com>, Hans Yang <hansy@nvidia.com>
Subject: [PATCH v3 2/2] USB hub_probe: put initialization before usage
Date: Mon, 7 Nov 2016 21:55:09 +0300 [thread overview]
Message-ID: <20161107185509.GA19018@vnote> (raw)
Minor optimization: move initialization immediately before usage.
This gives a chance for more accurate register allocation by the compiler.
Signed-off-by: Eugene Korenevsky <ekorenevsky@gmail.com>
---
drivers/usb/core/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 7a20980..c7f6b5f 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -1742,7 +1742,6 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
struct usb_device *hdev;
struct usb_hub *hub;
- desc = intf->cur_altsetting;
hdev = interface_to_usbdev(intf);
/*
@@ -1813,6 +1812,7 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
}
#endif
+ desc = intf->cur_altsetting;
if (!hub_check_descriptor_sanity(desc)) {
dev_err(&intf->dev, "bad descriptor, ignoring hub\n");
return -EIO;
--
2.10.2
next reply other threads:[~2016-11-07 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 18:55 Eugene Korenevsky [this message]
2016-11-08 6:52 ` [PATCH v3 2/2] USB hub_probe: put initialization before usage Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107185509.GA19018@vnote \
--to=ekorenevsky@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=chasemetzger15@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansy@nvidia.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).