From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933643AbcKGSz1 (ORCPT ); Mon, 7 Nov 2016 13:55:27 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35479 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933560AbcKGSzR (ORCPT ); Mon, 7 Nov 2016 13:55:17 -0500 Date: Mon, 7 Nov 2016 21:55:09 +0300 From: Eugene Korenevsky To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman , Luiz Capitulino , Linus Torvalds , Chase Metzger , Alan Stern , Mathias Nyman , Lu Baolu , Oliver Neukum , Hans Yang Subject: [PATCH v3 2/2] USB hub_probe: put initialization before usage Message-ID: <20161107185509.GA19018@vnote> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Minor optimization: move initialization immediately before usage. This gives a chance for more accurate register allocation by the compiler. Signed-off-by: Eugene Korenevsky --- drivers/usb/core/hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 7a20980..c7f6b5f 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1742,7 +1742,6 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id) struct usb_device *hdev; struct usb_hub *hub; - desc = intf->cur_altsetting; hdev = interface_to_usbdev(intf); /* @@ -1813,6 +1812,7 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id) } #endif + desc = intf->cur_altsetting; if (!hub_check_descriptor_sanity(desc)) { dev_err(&intf->dev, "bad descriptor, ignoring hub\n"); return -EIO; -- 2.10.2