* [PATCH] ARM: spear: Fix error handling
@ 2016-10-29 13:58 Christophe JAILLET
2016-10-31 16:18 ` Russell King - ARM Linux
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christophe JAILLET @ 2016-10-29 13:58 UTC (permalink / raw)
To: vireshk, shiraz.linux.kernel, linux
Cc: linux-arm-kernel, linux-kernel, kernel-janitors,
Christophe JAILLET
'clk_get_sys()' returns an error pointer in case of error, not NULL. So
test it with IS_ERR.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
arch/arm/mach-spear/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-spear/time.c b/arch/arm/mach-spear/time.c
index 9ccffc1d0f28..4878ba90026d 100644
--- a/arch/arm/mach-spear/time.c
+++ b/arch/arm/mach-spear/time.c
@@ -233,7 +233,7 @@ void __init spear_setup_of_timer(void)
}
gpt_clk = clk_get_sys("gpt0", NULL);
- if (!gpt_clk) {
+ if (IS_ERR(gpt_clk)) {
pr_err("%s:couldn't get clk for gpt\n", __func__);
goto err_iomap;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: spear: Fix error handling
2016-10-29 13:58 [PATCH] ARM: spear: Fix error handling Christophe JAILLET
@ 2016-10-31 16:18 ` Russell King - ARM Linux
2016-11-02 2:25 ` Viresh Kumar
2016-11-07 21:16 ` Olof Johansson
2 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2016-10-31 16:18 UTC (permalink / raw)
To: Christophe JAILLET, arm
Cc: vireshk, shiraz.linux.kernel, linux-arm-kernel, linux-kernel,
kernel-janitors
For the spear or arm-soc guys to deal with...
On Sat, Oct 29, 2016 at 03:58:39PM +0200, Christophe JAILLET wrote:
> 'clk_get_sys()' returns an error pointer in case of error, not NULL. So
> test it with IS_ERR.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> arch/arm/mach-spear/time.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-spear/time.c b/arch/arm/mach-spear/time.c
> index 9ccffc1d0f28..4878ba90026d 100644
> --- a/arch/arm/mach-spear/time.c
> +++ b/arch/arm/mach-spear/time.c
> @@ -233,7 +233,7 @@ void __init spear_setup_of_timer(void)
> }
>
> gpt_clk = clk_get_sys("gpt0", NULL);
> - if (!gpt_clk) {
> + if (IS_ERR(gpt_clk)) {
> pr_err("%s:couldn't get clk for gpt\n", __func__);
> goto err_iomap;
> }
> --
> 2.9.3
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: spear: Fix error handling
2016-10-29 13:58 [PATCH] ARM: spear: Fix error handling Christophe JAILLET
2016-10-31 16:18 ` Russell King - ARM Linux
@ 2016-11-02 2:25 ` Viresh Kumar
2016-11-07 21:16 ` Olof Johansson
2 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2016-11-02 2:25 UTC (permalink / raw)
To: Christophe JAILLET
Cc: vireshk, Shiraz HASHIM, linux,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors
On Sat, Oct 29, 2016 at 7:28 PM, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> 'clk_get_sys()' returns an error pointer in case of error, not NULL. So
> test it with IS_ERR.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> arch/arm/mach-spear/time.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: spear: Fix error handling
2016-10-29 13:58 [PATCH] ARM: spear: Fix error handling Christophe JAILLET
2016-10-31 16:18 ` Russell King - ARM Linux
2016-11-02 2:25 ` Viresh Kumar
@ 2016-11-07 21:16 ` Olof Johansson
2 siblings, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2016-11-07 21:16 UTC (permalink / raw)
To: Christophe JAILLET
Cc: vireshk, shiraz.linux.kernel, linux, linux-arm-kernel,
linux-kernel, kernel-janitors
On Sat, Oct 29, 2016 at 03:58:39PM +0200, Christophe JAILLET wrote:
> 'clk_get_sys()' returns an error pointer in case of error, not NULL. So
> test it with IS_ERR.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied to fixes-non-critical, thanks.
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-08 1:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-29 13:58 [PATCH] ARM: spear: Fix error handling Christophe JAILLET
2016-10-31 16:18 ` Russell King - ARM Linux
2016-11-02 2:25 ` Viresh Kumar
2016-11-07 21:16 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).