From: Olof Johansson <olof@lixom.net>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: jun.nie@linaro.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ARM: zx: Fix error handling
Date: Mon, 7 Nov 2016 13:18:49 -0800 [thread overview]
Message-ID: <20161107211849.GB2106@localhost> (raw)
In-Reply-To: <20161030081010.14735-1-christophe.jaillet@wanadoo.fr>
On Sun, Oct 30, 2016 at 09:10:10AM +0100, Christophe JAILLET wrote:
> 'devm_ioremap_resource()' returns an error pointer in case of error, not
> NULL. So test it with IS_ERR.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> 'return -EIO;' could also be turned into 'return PTR_ERR(pcubase);' in
> order to propagate the error value.
Applied to fixes-non-critical. Thanks!
-Olof
prev parent reply other threads:[~2016-11-08 1:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 8:10 [PATCH] ARM: zx: Fix error handling Christophe JAILLET
2016-10-31 16:20 ` Russell King - ARM Linux
2016-11-07 21:18 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107211849.GB2106@localhost \
--to=olof@lixom.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jun.nie@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).