From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503AbcKHBtM (ORCPT ); Mon, 7 Nov 2016 20:49:12 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:32821 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbcKHBtK (ORCPT ); Mon, 7 Nov 2016 20:49:10 -0500 Date: Mon, 7 Nov 2016 17:49:07 -0800 From: Dmitry Torokhov To: Nick Dyer Cc: Andrew Duggan , Chris Healy , Henrik Rydberg , Benjamin Tissoires , Linus Walleij , Bjorn Andersson , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/7] Input: synaptics-rmi4 - add a couple of debug lines Message-ID: <20161108014907.GD10133@dtor-ws> References: <1477345917-25326-1-git-send-email-nick@shmanahar.org> <1477345917-25326-3-git-send-email-nick@shmanahar.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477345917-25326-3-git-send-email-nick@shmanahar.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2016 at 10:51:52PM +0100, Nick Dyer wrote: > Signed-off-by: Nick Dyer Applied, thank you. > --- > drivers/input/rmi4/rmi_bus.c | 3 +++ > drivers/input/rmi4/rmi_driver.c | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c > index ef8c747..3c6a1b5 100644 > --- a/drivers/input/rmi4/rmi_bus.c > +++ b/drivers/input/rmi4/rmi_bus.c > @@ -230,6 +230,9 @@ int rmi_register_function(struct rmi_function *fn) > > void rmi_unregister_function(struct rmi_function *fn) > { > + rmi_dbg(RMI_DEBUG_CORE, &fn->dev, "Unregistering F%02X.\n", > + fn->fd.function_number); > + > device_del(&fn->dev); > of_node_put(fn->dev.of_node); > put_device(&fn->dev); > diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c > index 63c9e22..adb3ee8 100644 > --- a/drivers/input/rmi4/rmi_driver.c > +++ b/drivers/input/rmi4/rmi_driver.c > @@ -722,6 +722,7 @@ static int rmi_initial_reset(struct rmi_device *rmi_dev, > return RMI_SCAN_DONE; > } > > + rmi_dbg(RMI_DEBUG_CORE, &rmi_dev->dev, "Sending reset\n"); > error = rmi_write_block(rmi_dev, cmd_addr, &cmd_buf, 1); > if (error) { > dev_err(&rmi_dev->dev, > -- > 2.7.4 > -- Dmitry