From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932507AbcKHGvY (ORCPT <rfc822;w@1wt.eu>);
        Tue, 8 Nov 2016 01:51:24 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:39584 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753276AbcKHGvX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Nov 2016 01:51:23 -0500
Date: Tue, 8 Nov 2016 07:51:31 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eugene Korenevsky <ekorenevsky@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Luiz Capitulino <lcapitulino@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Chase Metzger <chasemetzger15@gmail.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Lu Baolu <baolu.lu@linux.intel.com>, Oliver Neukum <oneukum@suse.com>,
        Hans Yang <hansy@nvidia.com>
Subject: Re: [PATCH v3 1/2] USB hub_probe: rework ugly
 goto-into-compound-statement
Message-ID: <20161108065131.GD13024@kroah.com>
References: <20161107185350.GA18986@vnote>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161107185350.GA18986@vnote>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 07, 2016 at 09:53:50PM +0300, Eugene Korenevsky wrote:
> Rework smelling code (goto inside compound statement). Perhaps this is
> legacy. Anyway such code is not appropriate for Linux kernel.
> 
> Signed-off-by: Eugene Korenevsky <ekorenevsky@gmail.com>
> ---
>  drivers/usb/core/hub.c | 33 ++++++++++++++++-----------------
>  1 file changed, 16 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index cbb1467..7a20980 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1722,10 +1722,23 @@ static void hub_disconnect(struct usb_interface *intf)
>  	kref_put(&hub->kref, hub_release);
>  }
>  
> +static int hub_check_descriptor_sanity(struct usb_host_interface *desc)
> +{
> +	/* Some hubs have a subclass of 1, which AFAICT according to the */
> +	/*  specs is not defined, but it works */
> +	if (desc->desc.bInterfaceSubClass != 1 &&
> +	    desc->desc.bInterfaceSubClass != 2)
> +		return 0;
> +	/* Multiple endpoints? What kind of mutant ninja-hub is this? */
> +	if (desc->desc.bNumEndpoints != 1)
> +		return 0;
> +	/* If it's not an interrupt in endpoint, we'd better punt! */
> +	return usb_endpoint_is_int_in(&desc->endpoint[0].desc);

Minor nit, put blank lines after each if statement to make it readable.

thanks,

greg k-h