From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932597AbcKHGwm (ORCPT <rfc822;w@1wt.eu>);
        Tue, 8 Nov 2016 01:52:42 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:40196 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752582AbcKHGwl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Nov 2016 01:52:41 -0500
Date: Tue, 8 Nov 2016 07:52:48 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eugene Korenevsky <ekorenevsky@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Luiz Capitulino <lcapitulino@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Chase Metzger <chasemetzger15@gmail.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Lu Baolu <baolu.lu@linux.intel.com>, Oliver Neukum <oneukum@suse.com>,
        Hans Yang <hansy@nvidia.com>
Subject: Re: [PATCH v3 2/2] USB hub_probe: put initialization before usage
Message-ID: <20161108065248.GE13024@kroah.com>
References: <20161107185509.GA19018@vnote>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161107185509.GA19018@vnote>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 07, 2016 at 09:55:09PM +0300, Eugene Korenevsky wrote:
> Minor optimization: move initialization immediately before usage.
> This gives a chance for more accurate register allocation by the compiler.

This is a probe function, a very slow path.  Don't do micro
optimizations where they are not needed, or can not be actually
measured.

Also please just cc: the needed mailing list and maintainer for the
patch, don't go overboard for such tiny stuff.

thanks,

greg k-h