linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] s390: remove unneeded dependency for gen_facilities
@ 2016-11-08  1:55 Masahiro Yamada
  2016-11-08  7:45 ` Heiko Carstens
  0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2016-11-08  1:55 UTC (permalink / raw)
  To: Martin Schwidefsky, Heiko Carstens, linux-s390
  Cc: Paul Bolle, Masahiro Yamada, linux-kernel

The dependency between the object and the source is handled by
scripts/Makefile.host, so only "hostprogs-y += gen_facilities"
is fine.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/s390/tools/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
index 6d9814c..4b5e1e4 100644
--- a/arch/s390/tools/Makefile
+++ b/arch/s390/tools/Makefile
@@ -9,7 +9,5 @@ define filechk_facilities.h
 	$(obj)/gen_facilities
 endef
 
-$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c
-
 include/generated/facilities.h: $(obj)/gen_facilities FORCE
 	$(call filechk,facilities.h)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] s390: remove unneeded dependency for gen_facilities
  2016-11-08  1:55 [PATCH] s390: remove unneeded dependency for gen_facilities Masahiro Yamada
@ 2016-11-08  7:45 ` Heiko Carstens
  2016-11-08  8:21   ` Martin Schwidefsky
  0 siblings, 1 reply; 3+ messages in thread
From: Heiko Carstens @ 2016-11-08  7:45 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: Martin Schwidefsky, linux-s390, Paul Bolle, linux-kernel

On Tue, Nov 08, 2016 at 10:55:47AM +0900, Masahiro Yamada wrote:
> The dependency between the object and the source is handled by
> scripts/Makefile.host, so only "hostprogs-y += gen_facilities"
> is fine.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  arch/s390/tools/Makefile | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
> index 6d9814c..4b5e1e4 100644
> --- a/arch/s390/tools/Makefile
> +++ b/arch/s390/tools/Makefile
> @@ -9,7 +9,5 @@ define filechk_facilities.h
>  	$(obj)/gen_facilities
>  endef
>  
> -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c
> -
>  include/generated/facilities.h: $(obj)/gen_facilities FORCE
>  	$(call filechk,facilities.h)

Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>

Martin, can you pick this one up too, please?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] s390: remove unneeded dependency for gen_facilities
  2016-11-08  7:45 ` Heiko Carstens
@ 2016-11-08  8:21   ` Martin Schwidefsky
  0 siblings, 0 replies; 3+ messages in thread
From: Martin Schwidefsky @ 2016-11-08  8:21 UTC (permalink / raw)
  To: Heiko Carstens; +Cc: Masahiro Yamada, linux-s390, Paul Bolle, linux-kernel

On Tue, 8 Nov 2016 08:45:28 +0100
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> On Tue, Nov 08, 2016 at 10:55:47AM +0900, Masahiro Yamada wrote:
> > The dependency between the object and the source is handled by
> > scripts/Makefile.host, so only "hostprogs-y += gen_facilities"
> > is fine.
> > 
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> > 
> >  arch/s390/tools/Makefile | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
> > index 6d9814c..4b5e1e4 100644
> > --- a/arch/s390/tools/Makefile
> > +++ b/arch/s390/tools/Makefile
> > @@ -9,7 +9,5 @@ define filechk_facilities.h
> >  	$(obj)/gen_facilities
> >  endef
> >  
> > -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c
> > -
> >  include/generated/facilities.h: $(obj)/gen_facilities FORCE
> >  	$(call filechk,facilities.h)
> 
> Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> 
> Martin, can you pick this one up too, please?

Done.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-08  8:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-08  1:55 [PATCH] s390: remove unneeded dependency for gen_facilities Masahiro Yamada
2016-11-08  7:45 ` Heiko Carstens
2016-11-08  8:21   ` Martin Schwidefsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).