From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org,
Sebastian Ott <sebott@linux.vnet.ibm.com>
Subject: Re: [PATCH] percpu: use notrace variant of preempt_disable/preempt_enable
Date: Tue, 8 Nov 2016 10:56:55 +0100 [thread overview]
Message-ID: <20161108105655.129ee2d7@mschwide> (raw)
In-Reply-To: <20161107122716.6e4597a7@gandalf.local.home>
On Mon, 7 Nov 2016 12:27:16 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 3 Nov 2016 14:58:38 +0100
> Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
>
> > Commit 345ddcc882d8 ("ftrace: Have set_ftrace_pid use the bitmap like
> > events do") added a couple of this_cpu_read calls to the ftrace code.
> >
> > On x86 this is not a problem, since it has single instructions to read
> > percpu data. Other architectures which use the generic variant now
> > have additional preempt_disable and preempt_enable calls in the core
> > ftrace code. This may lead to recursive calls and in result to a dead
> > machine, e.g. if preemption and debugging options are enabled.
> >
> > To fix this use the notrace variant of preempt_disable and
> > preempt_enable within the generic percpu code.
> >
> > Reported-and-bisected-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
> > Tested-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
> > Fixes: 345ddcc882d8 ("ftrace: Have set_ftrace_pid use the bitmap like events do")
> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
>
> Feel free to push this in your tree.
Ok, will do. Thanks.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
prev parent reply other threads:[~2016-11-08 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 13:58 [PATCH] percpu: use notrace variant of preempt_disable/preempt_enable Heiko Carstens
2016-11-07 17:27 ` Steven Rostedt
2016-11-08 9:56 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108105655.129ee2d7@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sebott@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox