From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: tca8418: Change the interrupt type
Date: Tue, 8 Nov 2016 16:04:00 -0800 [thread overview]
Message-ID: <20161109000400.GA8719@dtor-ws> (raw)
In-Reply-To: <20161107144024.15291-1-maxime.ripard@free-electrons.com>
On Mon, Nov 07, 2016 at 03:40:24PM +0100, Maxime Ripard wrote:
> The TCA8418 interrupt has a level trigger, not a edge one.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Hmm, maybe we could rely on OF data for trigger type?
> ---
> drivers/input/keyboard/tca8418_keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/tca8418_keypad.c b/drivers/input/keyboard/tca8418_keypad.c
> index 9002298698fc..b88b3696a2e1 100644
> --- a/drivers/input/keyboard/tca8418_keypad.c
> +++ b/drivers/input/keyboard/tca8418_keypad.c
> @@ -360,7 +360,7 @@ static int tca8418_keypad_probe(struct i2c_client *client,
> irq = gpio_to_irq(irq);
>
> error = devm_request_threaded_irq(dev, irq, NULL, tca8418_irq_handler,
> - IRQF_TRIGGER_FALLING |
> + IRQF_TRIGGER_LOW |
> IRQF_SHARED |
> IRQF_ONESHOT,
> client->name, keypad_data);
> --
> 2.10.1
>
--
Dmitry
next prev parent reply other threads:[~2016-11-09 0:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 14:40 [PATCH] drivers: tca8418: Change the interrupt type Maxime Ripard
2016-11-09 0:04 ` Dmitry Torokhov [this message]
2016-11-09 8:02 ` Maxime Ripard
2016-11-10 4:02 ` Dmitry Torokhov
2016-11-10 9:13 ` Maxime Ripard
2016-11-12 1:24 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109000400.GA8719@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).