Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

Mark Brown
2016-11-14T12:06:12Z

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote:
> On Thu, Nov 10 2016, Baolin Wang wrote:

> > Fourth, we need integrate all charger plugin/out
> > event in one framework, not from extcon, maybe type-c in future.

> Why not extcon? Given that a charger is connected by an external
> connector, extcon seems like exactly the right thing to use.

> Obviously extcon doesn't report the current that was negotiated, but
> that is best kept separate. The battery charger can be advised of the
> available current either via extcon or separately via the usb
> subsystem. Don't conflate the two.

Conflating the two seems like the whole point here. We're looking for
something that sits between the power supply code and the USB code and
tells the power supply code what it's allowed to do which is the result
of a combination of physical cable detection and USB protocol. It seems
reasonable that extcon drivers ought to be part of this but it doesn't
seem like they are the whole story.

> > word, we need one standard integration of this feature we need, though
> > like you said we should do some clean up or fix to make it better.

> But really, I'm not the person you need to convince. I'm just a vaguely
> interested bystander who is rapidly losing interest. You need to
> convince a maintainer, but they have so far shown remarkably little
> interest. I don't know why, but I'd guess that reviewing a complex new
> subsystem isn't much fun. Reviewing and applying clear bugfixes and
> incremental improvements is much easier and more enjoyable. But that is
> just a guess.

OTOH having someone else having reviewed might help them apply something
they don't care about.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]