From: Ingo Molnar <mingo@kernel.org>
To: Michal Marek <mmarek@suse.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
x86@kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
Ben Hutchings <ben@decadent.org.uk>,
Sven Joachim <svenjoac@gmx.de>,
"Austin S. Hemmelgarn" <ahferroin7@gmail.com>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 1/3] kbuild: add -fno-PIE
Date: Wed, 9 Nov 2016 07:10:42 +0100 [thread overview]
Message-ID: <20161109061041.GA19246@gmail.com> (raw)
In-Reply-To: <20161108221437.GA9197@sepie.suse.cz>
* Michal Marek <mmarek@suse.com> wrote:
> On Fri, Nov 04, 2016 at 07:39:38PM +0100, Sebastian Andrzej Siewior wrote:
> > Debian started to build the gcc with -fPIE by default so the kernel
> > build ends before it starts properly with:
> > |kernel/bounds.c:1:0: error: code model kernel does not support PIC mode
> >
> > Also add to KBUILD_AFLAGS due to:
> >
> > |gcc -Wp,-MD,arch/x86/entry/vdso/vdso32/.note.o.d … -mfentry -DCC_USING_FENTRY … vdso/vdso32/note.S
> > |arch/x86/entry/vdso/vdso32/note.S:1:0: sorry, unimplemented: -mfentry isn’t supported for 32-bit in combination with -fpic
> >
> > Tagging it stable so it is possible to compile recent stable kernels as
> > well.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> > Makefile | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Makefile b/Makefile
> > index a2650f9c6a25..d61145ebf498 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -622,6 +622,8 @@ include arch/$(SRCARCH)/Makefile
> > KBUILD_CFLAGS += $(call cc-option,-fno-delete-null-pointer-checks,)
> > KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,)
> > KBUILD_CFLAGS += $(call cc-disable-warning,frame-address,)
> > +KBUILD_CFLAGS += $(call cc-option,-fno-PIE)
> > +KBUILD_AFLAGS += $(call cc-option,-fno-PIE)
>
> Bad compiler. No pie for you.
>
> I applied this one to kbuild.git. How about 2/3 and 3/3. Will these be
> merged via tip.git or shall I apply them as well?
I'd suggest applying them to the kbuild tree, as they are related.
Thanks,
Ingo
next prev parent reply other threads:[~2016-11-09 6:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 18:39 -fno-PIE, take #3 Sebastian Andrzej Siewior
2016-11-04 18:39 ` [PATCH 1/3] kbuild: add -fno-PIE Sebastian Andrzej Siewior
2016-11-08 22:14 ` Michal Marek
2016-11-09 6:10 ` Ingo Molnar [this message]
2016-11-09 21:29 ` Michal Marek
2016-11-10 9:25 ` Ingo Molnar
2016-11-04 18:39 ` [PATCH 2/3] scripts/has-stack-protector: " Sebastian Andrzej Siewior
2016-11-04 18:39 ` [PATCH 3/3] x86/kexec: " Sebastian Andrzej Siewior
2016-11-07 6:30 ` -fno-PIE, take #3 Theodore Ts'o
2016-11-07 22:31 ` H. Peter Anvin
2016-11-08 13:42 ` Borislav Petkov
2016-11-08 22:51 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109061041.GA19246@gmail.com \
--to=mingo@kernel.org \
--cc=ahferroin7@gmail.com \
--cc=ben@decadent.org.uk \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=svenjoac@gmx.de \
--cc=viro@ZenIV.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).