From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934089AbcKIQTy (ORCPT ); Wed, 9 Nov 2016 11:19:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33284 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933033AbcKIQTx (ORCPT ); Wed, 9 Nov 2016 11:19:53 -0500 Date: Wed, 9 Nov 2016 17:19:48 +0100 From: Jiri Benc To: Arnd Bergmann Cc: "David S. Miller" , Hannes Frederic Sowa , Alexander Duyck , pravin shelar , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vxlan: hide unused local variable Message-ID: <20161109171948.4bbc9615@griffin> In-Reply-To: <20161107211017.857340-1-arnd@arndb.de> References: <20161107211017.857340-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 09 Nov 2016 16:19:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Nov 2016 22:09:07 +0100, Arnd Bergmann wrote: > A bugfix introduced a harmless warning in v4.9-rc4: > > drivers/net/vxlan.c: In function 'vxlan_group_used': > drivers/net/vxlan.c:947:21: error: unused variable 'sock6' [-Werror=unused-variable] > > This hides the variable inside of the same #ifdef that is > around its user. The extraneous initialization is removed > at the same time, it was accidentally introduced in the > same commit. > > Fixes: c6fcc4fc5f8b ("vxlan: avoid using stale vxlan socket.") > Signed-off-by: Arnd Bergmann I think this should be applied instead of Pravin's patch. It fixes just the one problem, contains the proper Fixes: tag and addresses net.git. Acked-by: Jiri Benc