From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754597AbcKIXBV (ORCPT ); Wed, 9 Nov 2016 18:01:21 -0500 Received: from one.firstfloor.org ([193.170.194.197]:37965 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbcKIXBU (ORCPT ); Wed, 9 Nov 2016 18:01:20 -0500 Date: Wed, 9 Nov 2016 15:01:17 -0800 From: Andi Kleen To: Andrew Morton Cc: Vitaly Wool , Linux-MM , linux-kernel@vger.kernel.org, Dan Streetman , Andi Kleen Subject: Re: [PATCH v3] z3fold: use per-page read/write lock Message-ID: <20161109230117.GO26852@two.firstfloor.org> References: <20161109115531.81d2a3fd4313236d483510f0@gmail.com> <20161109143304.538885b06a4b5d2289da1e52@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161109143304.538885b06a4b5d2289da1e52@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 09, 2016 at 02:33:04PM -0800, Andrew Morton wrote: > On Wed, 9 Nov 2016 11:55:31 +0100 Vitaly Wool wrote: > > > Subject: [PATCH v3] z3fold: use per-page read/write lock > > I've rewritten the title to "mm/z3fold.c: use per-page spinlock" > > (I prefer to have "mm" in the title to easily identify it as an MM > patch, and using "mm: z3fold: ..." seems odd when the actual pathname > conveys the same info.) Still think it needs to be raw_spinlock_t, otherwise the build bug on on the header size will break again. Better would be to fix that build bug though -Andi