From: Mark Rutland <mark.rutland@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kan.liang@intel.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, acme@kernel.org,
tglx@linutronix.de, alexander.shishkin@linux.intel.com,
vince@deater.net, eranian@google.com, andi@firstfloor.org
Subject: Re: [PATCH] perf/core: introduce context per CPU event list
Date: Thu, 10 Nov 2016 11:05:17 +0000 [thread overview]
Message-ID: <20161110110516.GA4418@leverpostej> (raw)
In-Reply-To: <20161110083355.GO3568@worktop.programming.kicks-ass.net>
Hi,
On Thu, Nov 10, 2016 at 09:33:55AM +0100, Peter Zijlstra wrote:
> Yes this is a problem, but no this cannot be done. We can't have per-cpu
> storage per task. That rapidly explodes.
>
> Mark is looking at replacing this stuff with an rb-tree for big-little,
> that would also allow improving this I think.
Unfortunately I've not had the chance to look at that since returning
from Plumbers. Also, I was leaning towards the alternative approach we
discussed, with a perf_event_task_contexts container, as that also
solved some other issues with the way we used perf_event_context::pmu in
big.LITTLE systems.
Looking at the way perf_iterate_ctx is used, it seems that we're just
trying to iterate over the active events for a context (i.e. those
programmed into the HW at this point in time). Though I'm missing some
subtlety, since we check event->state < PERF_EVENT_STATE_INACTIVE.
We have a similar issue with perf_event_task_tick() needing to know the
relevant contexts, and for that we have the active_ctx_list. Can't we do
something similar and add an active_events_list to perf_event_context?
Thanks,
Mark.
next prev parent reply other threads:[~2016-11-10 11:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 19:04 [PATCH] perf/core: introduce context per CPU event list kan.liang
2016-11-10 8:33 ` Peter Zijlstra
2016-11-10 11:05 ` Mark Rutland [this message]
2016-11-10 11:37 ` Peter Zijlstra
2016-11-10 12:04 ` Mark Rutland
2016-11-10 12:12 ` Peter Zijlstra
2016-11-10 12:26 ` Mark Rutland
2016-11-10 12:58 ` Peter Zijlstra
2016-11-10 14:10 ` Mark Rutland
2016-11-10 14:31 ` Liang, Kan
2016-11-10 16:26 ` Peter Zijlstra
2016-11-10 17:01 ` Mark Rutland
[not found] ` <1483302059-4334-1-git-send-email-davidcc@google.com>
2017-01-01 21:18 ` David Carrillo-Cisneros
2017-01-03 12:00 ` Mark Rutland
2017-01-04 0:39 ` David Carrillo-Cisneros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110110516.GA4418@leverpostej \
--to=mark.rutland@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox