From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933306AbcKJNfz (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Nov 2016 08:35:55 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:48442 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932825AbcKJNfx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Nov 2016 08:35:53 -0500
Date: Thu, 10 Nov 2016 14:35:59 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mmc@vger.kernel.org, Jarkko Lavinen <jarkko.lavinen@nokia.com>,
        Rui Miguel Silva <rmfrfs@gmail.com>, linux-kernel@vger.kernel.org,
        Nicolas Pitre <nico@fluxnic.net>, devel@driverdev.osuosl.org,
        Jaehoon Chung <jh80.chung@samsung.com>,
        Pierre Ossman <pierre@ossman.eu>, Johan Hovold <johan@kernel.org>,
        Alex Dubov <oakad@yahoo.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Tony Olech <tony.olech@elandigitalsystems.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Sascha Sommer <saschasommer@freenet.de>,
        adi-buildroot-devel@lists.sourceforge.net,
        Ben Dooks <ben-linux@fluff.org>, Alex Elder <elder@kernel.org>,
        linux-mediatek@lists.infradead.org,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Tony Prisk <linux@prisktech.co.nz>, linux-omap@vger.kernel.org,
        Manuel Lauss <manuel.lauss@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Ludovic Desroches <ludovic.desroches@atmel.com>,
        linux-usb@vger.kernel.org, Bruce Chang <brucechang@via.com.tw>,
        Sonic Zhang <sonic.zhang@analog.com>,
        Harald Welte <HaraldWelte@viatech.com>, Chen-Yu Tsai <wens@csie.org>,
        Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()
Message-ID: <20161110133559.GA10191@kroah.com>
References: <1478784263-18777-1-git-send-email-yamada.masahiro@socionext.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1478784263-18777-1-git-send-email-yamada.masahiro@socionext.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote:
> 
> sdhci_alloc_host() returns an error pointer when it fails.
> but mmc_alloc_host() cannot.
> 
> This series allow to propagate a proper error code
> when host-allocation fails.

Why?  What can we really do about the error except give up?  Why does
having a explicit error value make any difference to the caller, they
can't do anything different, right?

I suggest just leaving it as-is, it's simple, and you don't have to mess
with PTR_ERR() anywhere.

thanks,

greg k-h