* [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'
2016-11-08 15:42 [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t' Shiva Kerdel
@ 2016-11-08 15:42 ` Shiva Kerdel
2016-11-08 23:52 ` Stuart Yoder
0 siblings, 1 reply; 7+ messages in thread
From: Shiva Kerdel @ 2016-11-08 15:42 UTC (permalink / raw)
To: stuart.yoder
Cc: gregkh, German.Rivera, german.rivera, treding, itai.katz,
nipun.gupta, linux-kernel, devel, Shiva Kerdel
Follow the kernel type preferrences of using 's32' over 'int32_t'.
Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
---
drivers/staging/fsl-mc/include/mc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h
index a781a36..1c46c0c 100644
--- a/drivers/staging/fsl-mc/include/mc.h
+++ b/drivers/staging/fsl-mc/include/mc.h
@@ -81,7 +81,7 @@ enum fsl_mc_pool_type {
*/
struct fsl_mc_resource {
enum fsl_mc_pool_type type;
- int32_t id;
+ s32 id;
void *data;
struct fsl_mc_resource_pool *parent_pool;
struct list_head node;
--
2.10.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'
2016-11-08 15:42 ` [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t' Shiva Kerdel
@ 2016-11-08 23:52 ` Stuart Yoder
0 siblings, 0 replies; 7+ messages in thread
From: Stuart Yoder @ 2016-11-08 23:52 UTC (permalink / raw)
To: Shiva Kerdel
Cc: gregkh@linuxfoundation.org, German.Rivera@freescale.com,
German Rivera, treding@nvidia.com, Nipun Gupta,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Laurentiu Tudor
> -----Original Message-----
> From: Shiva Kerdel [mailto:shiva@exdev.nl]
> Sent: Tuesday, November 08, 2016 9:42 AM
> To: Stuart Yoder <stuart.yoder@nxp.com>
> Cc: gregkh@linuxfoundation.org; German.Rivera@freescale.com; German Rivera <german.rivera@nxp.com>;
> treding@nvidia.com; itai.katz@nxp.com; Nipun Gupta <nipun.gupta@nxp.com>; linux-kernel@vger.kernel.org;
> devel@driverdev.osuosl.org; Shiva Kerdel <shiva@exdev.nl>
> Subject: [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'
>
> Follow the kernel type preferrences of using 's32' over 'int32_t'.
>
> Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
> ---
> drivers/staging/fsl-mc/include/mc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h
> index a781a36..1c46c0c 100644
> --- a/drivers/staging/fsl-mc/include/mc.h
> +++ b/drivers/staging/fsl-mc/include/mc.h
> @@ -81,7 +81,7 @@ enum fsl_mc_pool_type {
> */
> struct fsl_mc_resource {
> enum fsl_mc_pool_type type;
> - int32_t id;
> + s32 id;
> void *data;
> struct fsl_mc_resource_pool *parent_pool;
> struct list_head node;
Acked-by: Stuart Yoder <stuart.yoder@nxp.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'
2016-11-10 14:09 Shiva Kerdel
@ 2016-11-10 14:09 ` Shiva Kerdel
0 siblings, 0 replies; 7+ messages in thread
From: Shiva Kerdel @ 2016-11-10 14:09 UTC (permalink / raw)
To: stuart.yoder
Cc: gregkh, German.Rivera, german.rivera, treding, itai.katz,
nipun.gupta, linux-kernel, devel, Shiva Kerdel
Follow the kernel type preferrences of using 's32' over 'int32_t'.
Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
Acked-by: Stuart Yoder <stuart.yoder@nxp.com>
---
drivers/staging/fsl-mc/include/mc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h
index a781a36..1c46c0c 100644
--- a/drivers/staging/fsl-mc/include/mc.h
+++ b/drivers/staging/fsl-mc/include/mc.h
@@ -81,7 +81,7 @@ enum fsl_mc_pool_type {
*/
struct fsl_mc_resource {
enum fsl_mc_pool_type type;
- int32_t id;
+ s32 id;
void *data;
struct fsl_mc_resource_pool *parent_pool;
struct list_head node;
--
2.10.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'
@ 2016-11-10 14:53 Shiva Kerdel
2016-11-10 14:53 ` [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t' Shiva Kerdel
2016-11-10 15:27 ` [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t' Greg KH
0 siblings, 2 replies; 7+ messages in thread
From: Shiva Kerdel @ 2016-11-10 14:53 UTC (permalink / raw)
To: stuart.yoder
Cc: gregkh, German.Rivera, german.rivera, treding, itai.katz,
nipun.gupta, linux-kernel, devel, Shiva Kerdel
Follow the kernel type preferrences of using 's16' over 'int16_t'.
Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
Acked-by: Stuart Yoder <stuart.yoder@nxp.com>
---
Changes for v2:
- corrected an error in the log message, wrote 's32' instead of 's16'.
Changes for v3:
- added the missing annotate of v2.
---
drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h
index e915574..c7cad87 100644
--- a/drivers/staging/fsl-mc/include/mc-bus.h
+++ b/drivers/staging/fsl-mc/include/mc-bus.h
@@ -42,8 +42,8 @@ struct msi_domain_info;
*/
struct fsl_mc_resource_pool {
enum fsl_mc_pool_type type;
- int16_t max_count;
- int16_t free_count;
+ s16 max_count;
+ s16 free_count;
struct mutex mutex; /* serializes access to free_list */
struct list_head free_list;
struct fsl_mc_bus *mc_bus;
--
2.10.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'
2016-11-10 14:53 [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t' Shiva Kerdel
@ 2016-11-10 14:53 ` Shiva Kerdel
2016-11-10 15:27 ` Greg KH
2016-11-10 15:27 ` [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t' Greg KH
1 sibling, 1 reply; 7+ messages in thread
From: Shiva Kerdel @ 2016-11-10 14:53 UTC (permalink / raw)
To: stuart.yoder
Cc: gregkh, German.Rivera, german.rivera, treding, itai.katz,
nipun.gupta, linux-kernel, devel, Shiva Kerdel
Follow the kernel type preferrences of using 's32' over 'int32_t'.
Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
Acked-by: Stuart Yoder <stuart.yoder@nxp.com>
---
drivers/staging/fsl-mc/include/mc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h
index a781a36..1c46c0c 100644
--- a/drivers/staging/fsl-mc/include/mc.h
+++ b/drivers/staging/fsl-mc/include/mc.h
@@ -81,7 +81,7 @@ enum fsl_mc_pool_type {
*/
struct fsl_mc_resource {
enum fsl_mc_pool_type type;
- int32_t id;
+ s32 id;
void *data;
struct fsl_mc_resource_pool *parent_pool;
struct list_head node;
--
2.10.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'
2016-11-10 14:53 [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t' Shiva Kerdel
2016-11-10 14:53 ` [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t' Shiva Kerdel
@ 2016-11-10 15:27 ` Greg KH
1 sibling, 0 replies; 7+ messages in thread
From: Greg KH @ 2016-11-10 15:27 UTC (permalink / raw)
To: Shiva Kerdel
Cc: stuart.yoder, devel, German.Rivera, nipun.gupta, linux-kernel,
german.rivera, treding, itai.katz
On Thu, Nov 10, 2016 at 03:53:30PM +0100, Shiva Kerdel wrote:
> Follow the kernel type preferrences of using 's16' over 'int16_t'.
>
> Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
> Acked-by: Stuart Yoder <stuart.yoder@nxp.com>
> ---
> Changes for v2:
> - corrected an error in the log message, wrote 's32' instead of 's16'.
> Changes for v3:
> - added the missing annotate of v2.
> ---
But your patch subject says "v2" :(
And there is no need for another --- line, please don't have that.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'
2016-11-10 14:53 ` [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t' Shiva Kerdel
@ 2016-11-10 15:27 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2016-11-10 15:27 UTC (permalink / raw)
To: Shiva Kerdel
Cc: stuart.yoder, devel, German.Rivera, nipun.gupta, linux-kernel,
german.rivera, treding, itai.katz
On Thu, Nov 10, 2016 at 03:53:31PM +0100, Shiva Kerdel wrote:
> Follow the kernel type preferrences of using 's32' over 'int32_t'.
>
> Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
> Acked-by: Stuart Yoder <stuart.yoder@nxp.com>
> ---
> drivers/staging/fsl-mc/include/mc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The changelog between v1, v2, and v3?
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-11-10 15:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 14:53 [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t' Shiva Kerdel
2016-11-10 14:53 ` [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t' Shiva Kerdel
2016-11-10 15:27 ` Greg KH
2016-11-10 15:27 ` [PATCH v2 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t' Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-11-10 14:09 Shiva Kerdel
2016-11-10 14:09 ` [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t' Shiva Kerdel
2016-11-08 15:42 [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t' Shiva Kerdel
2016-11-08 15:42 ` [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t' Shiva Kerdel
2016-11-08 23:52 ` Stuart Yoder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).