From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934691AbcKJQQX (ORCPT ); Thu, 10 Nov 2016 11:16:23 -0500 Received: from 8bytes.org ([81.169.241.247]:60910 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934058AbcKJQQV (ORCPT ); Thu, 10 Nov 2016 11:16:21 -0500 Date: Thu, 10 Nov 2016 17:16:19 +0100 From: Joerg Roedel To: Robin Murphy Cc: Eric Auger , eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com Subject: Re: [RFC v2 8/8] iommu/arm-smmu: implement add_reserved_regions callback Message-ID: <20161110161619.GK2078@8bytes.org> References: <1478258646-3117-1-git-send-email-eric.auger@redhat.com> <1478258646-3117-9-git-send-email-eric.auger@redhat.com> <20161110154606.GH2078@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2016 at 04:07:08PM +0000, Robin Murphy wrote: > On 10/11/16 15:46, Joerg Roedel wrote: > > On Fri, Nov 04, 2016 at 11:24:06AM +0000, Eric Auger wrote: > >> + resource_list_for_each_entry(window, &bridge->windows) { > >> + if (resource_type(window->res) != IORESOURCE_MEM && > >> + resource_type(window->res) != IORESOURCE_IO) > >> + continue; > > > > Why do you care about IO resources? > > [since this is essentially code I wrote] > > Because they occupy some area of the PCI address space, therefore I > assumed that, like memory windows, they would be treated as P2P. Is that > not the case? No, not at all. The IO-space is completly seperate from the MEM-space. They are two different address-spaces, addressing different things. And the IO-space is also not translated by any IOMMU I am aware of. Joerg