From: Peter Zijlstra <peterz@infradead.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: kan.liang@intel.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, acme@kernel.org,
tglx@linutronix.de, alexander.shishkin@linux.intel.com,
vince@deater.net, eranian@google.com, andi@firstfloor.org
Subject: Re: [PATCH] perf/core: introduce context per CPU event list
Date: Thu, 10 Nov 2016 17:26:32 +0100 [thread overview]
Message-ID: <20161110162632.GY3142@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20161110141037.GE4418@leverpostej>
On Thu, Nov 10, 2016 at 02:10:37PM +0000, Mark Rutland wrote:
> Sure, that sounds fine for scheduling (including big.LITTLE).
>
> I might still be misunderstanding something, but I don't think that
> helps Kan's case: since INACTIVE events which will fail their filters
> (including the CPU check) will still be in the tree, they will still
> have to be iterated over.
>
> That is, unless we also sort the tree by event->cpu, or if in those
> cases we only care about ACTIVE events and can use an active list.
A few emails back up I wrote:
>> If we stick all events in an RB-tree sorted on: {pmu,cpu,runtime} we
Looking at the code there's also cgroup muck, not entirely sure where in
the sort order that should go if at all.
But having pmu and cpu in there would cure the big-little and
per-task-per-cpu event issues.
next prev parent reply other threads:[~2016-11-10 16:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 19:04 [PATCH] perf/core: introduce context per CPU event list kan.liang
2016-11-10 8:33 ` Peter Zijlstra
2016-11-10 11:05 ` Mark Rutland
2016-11-10 11:37 ` Peter Zijlstra
2016-11-10 12:04 ` Mark Rutland
2016-11-10 12:12 ` Peter Zijlstra
2016-11-10 12:26 ` Mark Rutland
2016-11-10 12:58 ` Peter Zijlstra
2016-11-10 14:10 ` Mark Rutland
2016-11-10 14:31 ` Liang, Kan
2016-11-10 16:26 ` Peter Zijlstra [this message]
2016-11-10 17:01 ` Mark Rutland
[not found] ` <1483302059-4334-1-git-send-email-davidcc@google.com>
2017-01-01 21:18 ` David Carrillo-Cisneros
2017-01-03 12:00 ` Mark Rutland
2017-01-04 0:39 ` David Carrillo-Cisneros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110162632.GY3142@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox