From: Dan Carpenter <dan.carpenter@oracle.com>
To: kys@microsoft.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com,
leann.ogasawara@canonical.com, sthemmin@microsoft.com,
Alex Ng <alexng@messages.microsoft.com>,
Alex Ng <alexng@microsoft.com>
Subject: Re: [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show max page count
Date: Thu, 10 Nov 2016 22:09:25 +0300 [thread overview]
Message-ID: <20161110190924.GD28701@mwanda> (raw)
In-Reply-To: <1478030854-5970-8-git-send-email-kys@exchange.microsoft.com>
On Tue, Nov 01, 2016 at 01:07:28PM -0700, kys@exchange.microsoft.com wrote:
> From: Alex Ng <alexng@messages.microsoft.com>
>
> Balloon driver was only printing the size of the info blob and not the
> actual content. This fixes it so that the info blob (max page count as
> configured in Hyper-V) is printed out.
>
> Signed-off-by: Alex Ng <alexng@microsoft.com>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
> drivers/hv/hv_balloon.c | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> index 8cac29a..14c3dc4 100644
> --- a/drivers/hv/hv_balloon.c
> +++ b/drivers/hv/hv_balloon.c
> @@ -1034,8 +1034,13 @@ static void process_info(struct hv_dynmem_device *dm, struct dm_info_msg *msg)
>
> switch (info_hdr->type) {
> case INFO_TYPE_MAX_PAGE_CNT:
> - pr_info("Received INFO_TYPE_MAX_PAGE_CNT\n");
> - pr_info("Data Size is %d\n", info_hdr->data_size);
> + if (info_hdr->data_size == sizeof(__u64)) {
> + __u64 *max_page_count = (__u64 *)&info_hdr[1];
Why __u64 instead of u64? Is this code shared with user space?
regards,
dan carpenter
next prev parent reply other threads:[~2016-11-10 19:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 20:06 [PATCH V2 00/14] Drivers: hv: Some miscellaneous fixes and enhancements kys
2016-11-01 20:07 ` [PATCH V2 01/14] Drivers: hv: ring_buffer: count on wrap around mappings in get_next_pkt_raw() (v2) kys
2016-11-01 20:07 ` [PATCH V2 02/14] Drivers: hv: utils: reduce HV_UTIL_NEGO_TIMEOUT timeout kys
2016-11-01 20:07 ` [PATCH V2 03/14] Drivers: hv: utils: Fix the mapping between host version and protocol to use kys
2016-11-01 20:07 ` [PATCH V2 04/14] Drivers: hv: balloon: Disable hot add when CONFIG_MEMORY_HOTPLUG is not set kys
2016-11-01 20:07 ` [PATCH V2 05/14] Drivers: hv: balloon: Add logging for dynamic memory operations kys
2016-11-01 20:07 ` [PATCH V2 06/14] Drivers: hv: vss: Improve log messages kys
2016-11-01 20:07 ` [PATCH V2 07/14] Drivers: hv: vss: Operation timeouts should match host expectation kys
2016-11-01 20:07 ` [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show max page count kys
2016-11-10 19:09 ` Dan Carpenter [this message]
2016-11-10 19:38 ` Alex Ng (LIS)
2016-11-01 20:07 ` [PATCH V2 09/14] tools: hv: remove unnecessary link flag kys
2016-11-01 20:07 ` [PATCH V2 10/14] tools: hv: fix a compile warning in snprintf kys
2016-11-01 20:07 ` [PATCH V2 11/14] tools: hv: remove unnecessary header files and netlink related code kys
2016-11-01 20:07 ` [PATCH V2 12/14] Drivers: hv: vmbus: Base host signaling strictly on the ring state kys
2016-11-01 20:07 ` [PATCH V2 13/14] Drivers: hv: vmbus: On write cleanup the logic to interrupt the host kys
2016-11-01 20:07 ` [PATCH V2 14/14] Drivers: hv: vmbus: On the read path " kys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110190924.GD28701@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alexng@messages.microsoft.com \
--cc=alexng@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox