From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935669AbcKJTS1 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Nov 2016 14:18:27 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:44211 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932259AbcKJTS0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Nov 2016 14:18:26 -0500
Date: Thu, 10 Nov 2016 22:17:23 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Anton Leshchenko <antonl1911@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Staging: vme: Use BIT macro for bit field
 definitions.
Message-ID: <20161110191723.GE28701@mwanda>
References: <20161101222711.17089-1-antonl1911@gmail.com>
 <20161101222711.17089-2-antonl1911@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161101222711.17089-2-antonl1911@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 02, 2016 at 01:27:09AM +0300, Anton Leshchenko wrote:
>  #define PIO2_CNTR_MODE0			0
> -#define PIO2_CNTR_MODE1			(1 << 1)
> -#define PIO2_CNTR_MODE2			(2 << 1)
> -#define PIO2_CNTR_MODE3			(3 << 1)
> -#define PIO2_CNTR_MODE4			(4 << 1)
> -#define PIO2_CNTR_MODE5			(5 << 1)
> +#define PIO2_CNTR_MODE1			BIT(1)
> +#define PIO2_CNTR_MODE2			BIT(2)
> +#define PIO2_CNTR_MODE3			(BIT(1) | BIT(2))
> +#define PIO2_CNTR_MODE4			BIT(4)

This should be BIT(3)

> +#define PIO2_CNTR_MODE5			(BIT(1) | BIT(3))

regards,
dan carpenter