From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965376AbcKJT0N (ORCPT ); Thu, 10 Nov 2016 14:26:13 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:28243 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965254AbcKJT0C (ORCPT ); Thu, 10 Nov 2016 14:26:02 -0500 Date: Thu, 10 Nov 2016 22:25:39 +0300 From: Dan Carpenter To: Jiri Kosina Cc: Benjamin Tissoires , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] HID: wacom: Don't clear bits unintentionally Message-ID: <20161110192539.GA32533@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.6.0 (2016-04-01) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is trying to clear the lower 32 bits but the type is wrong so it clears everything. Signed-off-by: Dan Carpenter diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 0723ba8..1cf4608 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -1765,7 +1765,7 @@ static int wacom_wac_pen_event(struct hid_device *hdev, struct hid_field *field, wacom_wac->hid_data.tipswitch |= value; return 0; case HID_DG_TOOLSERIALNUMBER: - wacom_wac->serial[0] = (wacom_wac->serial[0] & ~0xFFFFFFFF); + wacom_wac->serial[0] = (wacom_wac->serial[0] & ~0xFFFFFFFFULL); wacom_wac->serial[0] |= value; return 0; case WACOM_HID_WD_SENSE: