From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755635AbcKKKfm (ORCPT ); Fri, 11 Nov 2016 05:35:42 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:37688 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751382AbcKKKfk (ORCPT ); Fri, 11 Nov 2016 05:35:40 -0500 Date: Fri, 11 Nov 2016 10:38:27 +0000 From: Lee Jones To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Linus Walleij , Mattias Wallin , Samuel Ortiz , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/6] mfd: audit and demodule drivers/mfd/ab* drivers Message-ID: <20161111103827.GE13638@dell> References: <20161030012440.10495-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161030012440.10495-1-paul.gortmaker@windriver.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 29 Oct 2016, Paul Gortmaker wrote: > Nothing new here ; just another instance where we had modular remove > and exit functions -- but the Makefile/Kconfig limited the use case to > being always built-in; hence the code is useless and needs removing. > > So we remove the dead code and the misleading hints of modularity from > these drivers, hoping that we manage to prevent some new drivers from > copying these same old mistakes into pending new drivers. > > Paul. > --- > > Cc: Lee Jones > Cc: Linus Walleij > Cc: Mattias Wallin > Cc: Samuel Ortiz > Cc: linux-arm-kernel@lists.infradead.org > > Paul Gortmaker (6): > mfd: ab3100-core: Make it explicitly non-modular > mfd: ab8500-core: Make it explicitly non-modular > mfd: ab8500-debugfs: Make it explicitly non-modular > mfd: ab8500-gpadc: Make it explicitly non-modular > mfd: ab8500: make sysctrl explicitly non-modular > mfd: abx500-core: drop unused MODULE_ tags from non-modular code Applied the series with Linus' Ack. > drivers/mfd/ab3100-core.c | 39 +++------------------------------------ > drivers/mfd/ab8500-core.c | 37 ++++++------------------------------- > drivers/mfd/ab8500-debugfs.c | 21 ++------------------- > drivers/mfd/ab8500-gpadc.c | 19 ++----------------- > drivers/mfd/ab8500-sysctrl.c | 9 ++++----- > drivers/mfd/abx500-core.c | 7 ++----- > 6 files changed, 19 insertions(+), 113 deletions(-) > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog