From: Dan Carpenter <dan.carpenter@oracle.com>
To: Shiva Kerdel <shiva@exdev.nl>
Cc: stuart.yoder@nxp.com, devel@driverdev.osuosl.org,
German.Rivera@freescale.com, gregkh@linuxfoundation.org,
nipun.gupta@nxp.com, linux-kernel@vger.kernel.org,
german.rivera@nxp.com, treding@nvidia.com, itai.katz@nxp.com
Subject: Re: [PATCH 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'
Date: Fri, 11 Nov 2016 14:24:27 +0300 [thread overview]
Message-ID: <20161111112426.GH28701@mwanda> (raw)
In-Reply-To: <20161111110740.1926-2-shiva@exdev.nl>
On Fri, Nov 11, 2016 at 12:07:40PM +0100, Shiva Kerdel wrote:
> Follow the kernel type preferrences of using 's32' over 'int32_t'.
>
> Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
> Acked-by: Stuart Yoder <stuart.yoder@nxp.com>
> ---
> Changes for v2:
> - None
> Changes for v3:
> - None
> Changes for v4:
> - corrected patch version number.
>
> drivers/staging/fsl-mc/include/mc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h
> index a781a36..1c46c0c 100644
> --- a/drivers/staging/fsl-mc/include/mc.h
> +++ b/drivers/staging/fsl-mc/include/mc.h
> @@ -81,7 +81,7 @@ enum fsl_mc_pool_type {
> */
> struct fsl_mc_resource {
> enum fsl_mc_pool_type type;
> - int32_t id;
> + s32 id;
Just use "int".
regards,
dan carpenter
next prev parent reply other threads:[~2016-11-11 11:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 11:07 [PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t' Shiva Kerdel
2016-11-11 11:07 ` [PATCH 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t' Shiva Kerdel
2016-11-11 11:24 ` Dan Carpenter [this message]
2016-11-11 11:23 ` [PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t' Dan Carpenter
2016-11-11 14:52 ` Stuart Yoder
2016-11-14 10:05 ` Dan Carpenter
2016-11-14 14:55 ` Stuart Yoder
2016-11-15 7:54 ` Shiva Kerdel
-- strict thread matches above, loose matches on Subject: below --
2016-11-10 13:52 Shiva Kerdel
2016-11-10 13:52 ` [PATCH 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t' Shiva Kerdel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111112426.GH28701@mwanda \
--to=dan.carpenter@oracle.com \
--cc=German.Rivera@freescale.com \
--cc=devel@driverdev.osuosl.org \
--cc=german.rivera@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=itai.katz@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nipun.gupta@nxp.com \
--cc=shiva@exdev.nl \
--cc=stuart.yoder@nxp.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).