From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932170AbcKNCze (ORCPT ); Sun, 13 Nov 2016 21:55:34 -0500 Received: from mga09.intel.com ([134.134.136.24]:36891 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbcKNCzb (ORCPT ); Sun, 13 Nov 2016 21:55:31 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,488,1473145200"; d="scan'208";a="191018700" Date: Mon, 14 Nov 2016 08:34:53 +0530 From: Vinod Koul To: Sinan Kaya Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] dmaengine: qcom_hidma: cleanup sysfs entries during remove Message-ID: <20161114030452.GH3000@localhost> References: <1476902566-26676-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476902566-26676-1-git-send-email-okaya@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 19, 2016 at 02:42:46PM -0400, Sinan Kaya wrote: > The 4.8-rc8 kernel is printing duplicate file entry warnings while removing > the HIDMA object. This is caused by stale sysfs entries remaining from the > previous execution. > > _sysfs_warn_dup+0x5c/0x78 > sysfs_add_file_mode_ns+0x13c/0x1c0 > sysfs_create_file_ns+0x2c/0x40 > device_create_file+0x54/0xa0 > hidma_probe+0x7c8/0x808 > > Create hidma_sysfs_init and hidma_sysfs_uninit functions and call them from > the probe and remove path. To do proper clean up, adding the attrs object > to the device data structure to keep it around until remove call is made. This doesnt apply for me, I think due to other patches applied.. -- ~Vinod