From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965690AbcKNDcd (ORCPT ); Sun, 13 Nov 2016 22:32:33 -0500 Received: from mga04.intel.com ([192.55.52.120]:2020 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753533AbcKNDc2 (ORCPT ); Sun, 13 Nov 2016 22:32:28 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,488,1473145200"; d="scan'208";a="901037017" Date: Mon, 14 Nov 2016 09:11:44 +0530 From: Vinod Koul To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Laxman Dewangan , Jon Hunter , Dan Williams , Stephen Warren , Thierry Reding , Alexandre Courbot , dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] dma: tegra210-adma: convert TEGRA210_ADMA from bool to tristate Message-ID: <20161114034144.GN3000@localhost> References: <20161022222510.11373-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161022222510.11373-1-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 22, 2016 at 06:25:10PM -0400, Paul Gortmaker wrote: > This driver currently uses modular infrastructure but is controlled > by a bool Kconfig. > > There is a general consensus from the DMA reviewers and maintainers > that "if it can be modular, it should be modular" in order to keep > the bzImage size under control for multi platform kernels. > > Build tested only. Also needed some new pm_clk symbols exported > before this commit is applied to tree in order to avoid modpost > errors like: > > ERROR: "pm_clk_add_clk" [drivers/dma/tegra210-adma.ko] undefined! > ERROR: "pm_clk_create" [drivers/dma/tegra210-adma.ko] undefined! > ERROR: "pm_clk_destroy" [drivers/dma/tegra210-adma.ko] undefined! > ERROR: "pm_clk_suspend" [drivers/dma/tegra210-adma.ko] undefined! > ERROR: "pm_clk_resume" [drivers/dma/tegra210-adma.ko] undefined! > > These were added as exports in the v4.8-rc1 merge window. Applied, thanks -- ~Vinod