From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935371AbcKNFPI (ORCPT ); Mon, 14 Nov 2016 00:15:08 -0500 Received: from mga01.intel.com ([192.55.52.88]:60499 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932132AbcKNFPF (ORCPT ); Mon, 14 Nov 2016 00:15:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,488,1473145200"; d="scan'208";a="1059109222" Date: Mon, 14 Nov 2016 10:54:27 +0530 From: Vinod Koul To: Arnd Bergmann Cc: Dan Williams , Sinan Kaya , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: qcom_hidma: hide MSI handler when unused Message-ID: <20161114052426.GZ3000@localhost> References: <20161108134937.1966206-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161108134937.1966206-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2016 at 02:48:59PM +0100, Arnd Bergmann wrote: > The newly added MSI support causes a harmless warning when MSI > is disabled: > > drivers/dma/qcom/hidma.c:558:20: error: 'hidma_chirq_handler_msi' defined but not used [-Werror=unused-function] > > This adds another #ifdef to match that around the users of the function. Applied, thanks -- ~Vinod