From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933551AbcKNGtw (ORCPT ); Mon, 14 Nov 2016 01:49:52 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36150 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753560AbcKNGts (ORCPT ); Mon, 14 Nov 2016 01:49:48 -0500 Date: Mon, 14 Nov 2016 07:49:59 +0100 From: Greg Kroah-Hartman To: Eugene Korenevsky , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Baolin Wang Subject: Re: [PATCH v5] USB hub_probe: rework ugly goto-into-compound-statement Message-ID: <20161114064959.GA29356@kroah.com> References: <20161113125358.GA12417@vnote> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161113125358.GA12417@vnote> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 13, 2016 at 03:53:58PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > Changes in v5: make `bool` a return type of `hub_check_descriptor_sanity()` > Changes in v4: fix typo > Changes in v3: extract the code to static function > Changes in v2: fix spaces instead of tab, add missing 'Signed-off-by' > > drivers/usb/core/hub.c | 35 ++++++++++++++++++----------------- > 1 file changed, 18 insertions(+), 17 deletions(-) > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index cbb1467..1a316a1 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -1722,10 +1722,25 @@ static void hub_disconnect(struct usb_interface *intf) > kref_put(&hub->kref, hub_release); > } > > +static bool hub_check_descriptor_sanity(struct usb_host_interface *desc) > +{ > + /* Some hubs have a subclass of 1, which AFAICT according to the */ > + /* specs is not defined, but it works */ > + if (desc->desc.bInterfaceSubClass != 0 && > + desc->desc.bInterfaceSubClass != 1) > + return false; > + > + /* Multiple endpoints? What kind of mutant ninja-hub is this? */ > + if (desc->desc.bNumEndpoints != 1) > + return false; > + > + /* If it's not an interrupt in endpoint, we'd better punt! */ > + return usb_endpoint_is_int_in(&desc->endpoint[0].desc) != 0; Ok, I'm going to be really pedantic here and ask that you spell this last statement out: if (usb...) return true; return false; thanks, greg k-h