From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933699AbcKNSMK (ORCPT ); Mon, 14 Nov 2016 13:12:10 -0500 Received: from smtprelay0015.hostedemail.com ([216.40.44.15]:45691 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754085AbcKNSMI (ORCPT ); Mon, 14 Nov 2016 13:12:08 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2197:2199:2393:2553:2559:2562:2693:2895:2899:3138:3139:3140:3141:3142:3354:3622:3653:3865:3867:3868:3871:4250:4321:4605:5007:6261:6609:7875:10004:10400:10848:10967:11026:11232:11657:11658:11914:12043:12291:12555:12679:12740:12760:12986:13439:14181:14659:14721:21080:21221:21451:30045:30054:30056:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: neck98_11df8387bf009 X-Filterd-Recvd-Size: 3615 Date: Mon, 14 Nov 2016 13:12:00 -0500 From: Steven Rostedt To: Masami Hiramatsu Cc: Shuah Khan , Shuah Khan , linux-kernel@vger.kernel.org, Ingo Molnar , Namhyung Kim , Tom Zanussi , linux-kselftest@vger.kernel.org Subject: Re: [PATCH -tip v2 2/6] selftests: ftrace: Initialize ftrace before each test Message-ID: <20161114131200.7aaaaa13@gandalf.local.home> In-Reply-To: <147781045018.11952.9286420015716639736.stgit@devbox> References: <147781042852.11952.2843145560116738189.stgit@devbox> <147781045018.11952.9286420015716639736.stgit@devbox> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 30 Oct 2016 15:54:10 +0900 Masami Hiramatsu wrote: > Reset ftrace to initial state before running each test. > This fixes some test cases to enable tracing before starting > trace test. This can avoid false-positive failure when > previous testcase fails while disabling tracing. > > Signed-off-by: Masami Hiramatsu > Suggested-by: Steven Rostedt > --- > tools/testing/selftests/ftrace/ftracetest | 2 +- > tools/testing/selftests/ftrace/test.d/functions | 25 +++++++++++++++++++++++ > 2 files changed, 26 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest > index 4c6a0bf..a03d366 100755 > --- a/tools/testing/selftests/ftrace/ftracetest > +++ b/tools/testing/selftests/ftrace/ftracetest > @@ -228,7 +228,7 @@ trap 'SIG_RESULT=$XFAIL' $SIG_XFAIL > > __run_test() { # testfile > # setup PID and PPID, $$ is not updated. > - (cd $TRACING_DIR; read PID _ < /proc/self/stat ; set -e; set -x; . $1) > + (cd $TRACING_DIR; read PID _ < /proc/self/stat; set -e; set -x; initialize_ftrace; . $1) > [ $? -ne 0 ] && kill -s $SIG_FAIL $SIG_PID > } > > diff --git a/tools/testing/selftests/ftrace/test.d/functions b/tools/testing/selftests/ftrace/test.d/functions > index c37262f..fbaf565 100644 > --- a/tools/testing/selftests/ftrace/test.d/functions > +++ b/tools/testing/selftests/ftrace/test.d/functions > @@ -23,3 +23,28 @@ reset_trigger() { # reset all current setting triggers > done > } > > +reset_events_filter() { # reset all current setting filters > + grep -v ^none events/*/*/filter | > + while read line; do > + echo 0 > `echo $line | cut -f1 -d:` > + done > +} > + > +disable_events() { > + echo 0 > events/enable > +} > + > +initialize_ftrace() { # Reset ftrace to initial-state > +# As the initial state, ftrace will be set to nop tracer, > +# no events, no triggers, no filters, no function filters, > +# no probes, and tracing on. > + disable_tracing > + reset_tracer > + reset_trigger > + reset_events_filter > + disable_events > + echo | tee set_ftrace_* set_graph_* stack_trace_filter set_event_pid I just disabled function graph tracing, and this causes every test to fail. tee: set_graph_*: Permission denied -- Steve > + echo > kprobe_events > + echo > uprobe_events > + enable_tracing > +}