From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932708AbcKNOqW (ORCPT <rfc822;w@1wt.eu>);
        Mon, 14 Nov 2016 09:46:22 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:34002 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752214AbcKNOqU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 14 Nov 2016 09:46:20 -0500
Date: Mon, 14 Nov 2016 15:46:30 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Anton Leshchenko <antonl1911@gmail.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Staging: vme: Use BIT macro for bit field
 definitions.
Message-ID: <20161114144630.GA3119@kroah.com>
References: <20161101222711.17089-1-antonl1911@gmail.com>
 <20161101222711.17089-2-antonl1911@gmail.com>
 <20161110191723.GE28701@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161110191723.GE28701@mwanda>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 10, 2016 at 10:17:23PM +0300, Dan Carpenter wrote:
> On Wed, Nov 02, 2016 at 01:27:09AM +0300, Anton Leshchenko wrote:
> >  #define PIO2_CNTR_MODE0			0
> > -#define PIO2_CNTR_MODE1			(1 << 1)
> > -#define PIO2_CNTR_MODE2			(2 << 1)
> > -#define PIO2_CNTR_MODE3			(3 << 1)
> > -#define PIO2_CNTR_MODE4			(4 << 1)
> > -#define PIO2_CNTR_MODE5			(5 << 1)
> > +#define PIO2_CNTR_MODE1			BIT(1)
> > +#define PIO2_CNTR_MODE2			BIT(2)
> > +#define PIO2_CNTR_MODE3			(BIT(1) | BIT(2))
> > +#define PIO2_CNTR_MODE4			BIT(4)
> 
> This should be BIT(3)

Ugh, there were other parts wrong with this now that I look closer.
I've now reverted it.

thanks,

greg k-h