From: Oleg Nesterov <oleg@redhat.com>
To: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
hartsjc@redhat.com, vbendel@redhat.com, vlovejoy@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: sched/autogroup: race if !sysctl_sched_autogroup_enabled ?
Date: Mon, 14 Nov 2016 16:14:48 +0100 [thread overview]
Message-ID: <20161114151447.GA23318@redhat.com> (raw)
In-Reply-To: <1479045544.12006.8.camel@gmx.de>
On 11/13, Mike Galbraith wrote:
>
> Autogroup never should have had knobs in the first place, and now, Oleg has
> discovered that the dynamic enable/disable capability either has become, or
> perhaps always was racy.
It was always racy afaics, even if sysctl_sched_autogroup_enabled doesn't
change. So this patch is not enough.
But the main reason I dislike it is that I can't backport it ;) rhel7 runs
with sysctl_sched_autogroup_enabled=0 by default, and users actually use
this knob to enable it dynamically.
Mike, et al, sorry for delay. I'll try to finally force myself to write the
comments and the changelog and send 2 (trivial) fixes today.
Oleg.
next prev parent reply other threads:[~2016-11-14 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 16:59 sched/autogroup: race if !sysctl_sched_autogroup_enabled ? Oleg Nesterov
2016-11-09 17:50 ` Peter Zijlstra
2016-11-10 13:09 ` Oleg Nesterov
2016-11-11 16:57 ` Oleg Nesterov
2016-11-13 13:59 ` Mike Galbraith
2016-11-14 15:14 ` Oleg Nesterov [this message]
2016-11-12 12:12 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114151447.GA23318@redhat.com \
--to=oleg@redhat.com \
--cc=efault@gmx.de \
--cc=hartsjc@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=vbendel@redhat.com \
--cc=vlovejoy@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).