From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935129AbcKNRhV (ORCPT <rfc822;w@1wt.eu>);
        Mon, 14 Nov 2016 12:37:21 -0500
Received: from mail-wm0-f52.google.com ([74.125.82.52]:35324 "EHLO
        mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932705AbcKNRhQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 14 Nov 2016 12:37:16 -0500
Date: Mon, 14 Nov 2016 17:40:10 +0000
From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Quentin Schulz <quentin.schulz@free-electrons.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: sun4i-gpadc: select regmap-irq
Message-ID: <20161114174010.GA4094@dell>
References: <20161031153246.3561667-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20161031153246.3561667-1-arnd@arndb.de>
User-Agent: Mutt/1.6.2 (2016-07-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 31 Oct 2016, Arnd Bergmann wrote:

> The new sun4i mfd driver is lacking a dependency, triggering very rarely
> int randconfig kernel builds:
> 
> drivers/mfd/sun4i-gpadc.o: In function `sun4i_gpadc_probe':
> sun4i-gpadc.c:(.text.sun4i_gpadc_probe+0x110): undefined reference to `devm_regmap_add_irq_chip'
> 
> This adds a 'select REGMAP_IRQ', as the other drivers with this problem do.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 30978295a1e8..3a4c43df9404 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -44,6 +44,7 @@ config MFD_SUN4I_GPADC
>  	tristate "Allwinner sunxi platforms' GPADC MFD driver"
>  	select MFD_CORE
>  	select REGMAP_MMIO
> +	select REGMAP_IRQ
>  	depends on ARCH_SUNXI || COMPILE_TEST
>  	help
>  	  Select this to get support for Allwinner SoCs (A10, A13 and A31) ADC.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog