* [PATCH] mfd: sun4i-gpadc: select regmap-irq
@ 2016-10-31 15:31 Arnd Bergmann
2016-11-14 17:40 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-10-31 15:31 UTC (permalink / raw)
To: Lee Jones; +Cc: Arnd Bergmann, Quentin Schulz, linux-kernel
The new sun4i mfd driver is lacking a dependency, triggering very rarely
int randconfig kernel builds:
drivers/mfd/sun4i-gpadc.o: In function `sun4i_gpadc_probe':
sun4i-gpadc.c:(.text.sun4i_gpadc_probe+0x110): undefined reference to `devm_regmap_add_irq_chip'
This adds a 'select REGMAP_IRQ', as the other drivers with this problem do.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 30978295a1e8..3a4c43df9404 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -44,6 +44,7 @@ config MFD_SUN4I_GPADC
tristate "Allwinner sunxi platforms' GPADC MFD driver"
select MFD_CORE
select REGMAP_MMIO
+ select REGMAP_IRQ
depends on ARCH_SUNXI || COMPILE_TEST
help
Select this to get support for Allwinner SoCs (A10, A13 and A31) ADC.
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: sun4i-gpadc: select regmap-irq
2016-10-31 15:31 [PATCH] mfd: sun4i-gpadc: select regmap-irq Arnd Bergmann
@ 2016-11-14 17:40 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2016-11-14 17:40 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Quentin Schulz, linux-kernel
On Mon, 31 Oct 2016, Arnd Bergmann wrote:
> The new sun4i mfd driver is lacking a dependency, triggering very rarely
> int randconfig kernel builds:
>
> drivers/mfd/sun4i-gpadc.o: In function `sun4i_gpadc_probe':
> sun4i-gpadc.c:(.text.sun4i_gpadc_probe+0x110): undefined reference to `devm_regmap_add_irq_chip'
>
> This adds a 'select REGMAP_IRQ', as the other drivers with this problem do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 30978295a1e8..3a4c43df9404 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -44,6 +44,7 @@ config MFD_SUN4I_GPADC
> tristate "Allwinner sunxi platforms' GPADC MFD driver"
> select MFD_CORE
> select REGMAP_MMIO
> + select REGMAP_IRQ
> depends on ARCH_SUNXI || COMPILE_TEST
> help
> Select this to get support for Allwinner SoCs (A10, A13 and A31) ADC.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-14 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-31 15:31 [PATCH] mfd: sun4i-gpadc: select regmap-irq Arnd Bergmann
2016-11-14 17:40 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox