From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935602AbcKNSWK (ORCPT ); Mon, 14 Nov 2016 13:22:10 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:35431 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932174AbcKNSWI (ORCPT ); Mon, 14 Nov 2016 13:22:08 -0500 Date: Mon, 14 Nov 2016 18:25:01 +0000 From: Lee Jones To: Johan Hovold Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: core: fix device reference leak in mfd_clone_cell Message-ID: <20161114182501.GC4094@dell> References: <1477996698-28870-1-git-send-email-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1477996698-28870-1-git-send-email-johan@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 01 Nov 2016, Johan Hovold wrote: > Make sure to drop the reference taken by bus_find_device_by_name() > before returning from mfd_clone_cell(). > > Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd") > Signed-off-by: Johan Hovold > --- > drivers/mfd/mfd-core.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > index 3ac486a597f3..c57e407020f1 100644 > --- a/drivers/mfd/mfd-core.c > +++ b/drivers/mfd/mfd-core.c > @@ -399,6 +399,8 @@ int mfd_clone_cell(const char *cell, const char **clones, size_t n_clones) > clones[i]); > } > > + put_device(dev); > + > return 0; > } > EXPORT_SYMBOL(mfd_clone_cell); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog