From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755267AbcKNX7k (ORCPT ); Mon, 14 Nov 2016 18:59:40 -0500 Received: from mga04.intel.com ([192.55.52.120]:15073 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965155AbcKNX7i (ORCPT ); Mon, 14 Nov 2016 18:59:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,640,1473145200"; d="scan'208";a="31267970" Date: Tue, 15 Nov 2016 07:58:55 +0800 From: kbuild test robot To: Ian Kent Cc: kbuild-all@01.org, Andrew Morton , Linux Memory Management List , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] vfs: fix boolreturn.cocci warnings Message-ID: <20161114235851.GA29411@intel17.lkp.intel.com> References: <201611150731.dUsDxUoh%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201611150731.dUsDxUoh%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fs/namespace.c:1185:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint' with return type bool fs/namespace.c:1199:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint_rcu' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Ian Kent Signed-off-by: Fengguang Wu --- namespace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/namespace.c +++ b/fs/namespace.c @@ -1182,7 +1182,7 @@ bool path_is_mountpoint(struct path *pat bool res; if (!d_mountpoint(path->dentry)) - return 0; + return false; rcu_read_lock(); res = __path_is_mountpoint(path); @@ -1196,7 +1196,7 @@ EXPORT_SYMBOL(path_is_mountpoint); bool path_is_mountpoint_rcu(struct path *path) { if (!d_mountpoint(path->dentry)) - return 0; + return false; return __path_is_mountpoint(path); }