From: Shiva Kerdel <shiva@exdev.nl>
To: stuart.yoder@nxp.com
Cc: gregkh@linuxfoundation.org, German.Rivera@freescale.com,
treding@nvidia.com, itai.katz@nxp.com,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Shiva Kerdel <shiva@exdev.nl>
Subject: [PATCH][RESPIN] Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16'
Date: Tue, 15 Nov 2016 09:30:03 +0100 [thread overview]
Message-ID: <20161115083003.6017-1-shiva@exdev.nl> (raw)
After following a discussion about the used integer types Dan Carpenter
pointed out that 'int' types should be used over the current change to
's16'. The reason for this is to have an upper bound instead of overflowing
the 's16' so we could still remove devices.
Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
Suggested-by: Stuart Yoder <stuart.yoder@nxp.com>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h
index c7cad87..42700de 100644
--- a/drivers/staging/fsl-mc/include/mc-bus.h
+++ b/drivers/staging/fsl-mc/include/mc-bus.h
@@ -42,8 +42,8 @@ struct msi_domain_info;
*/
struct fsl_mc_resource_pool {
enum fsl_mc_pool_type type;
- s16 max_count;
- s16 free_count;
+ int max_count;
+ int free_count;
struct mutex mutex; /* serializes access to free_list */
struct list_head free_list;
struct fsl_mc_bus *mc_bus;
--
2.10.2
next reply other threads:[~2016-11-15 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 8:30 Shiva Kerdel [this message]
2016-11-15 10:02 ` [PATCH][RESPIN] Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16' Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115083003.6017-1-shiva@exdev.nl \
--to=shiva@exdev.nl \
--cc=German.Rivera@freescale.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=itai.katz@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stuart.yoder@nxp.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).