The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	arve@android.com, riandrews@android.com
Subject: Re: [V2] android: binder: use VM_ALLOC to get vm area
Date: Tue, 15 Nov 2016 11:18:56 +0100	[thread overview]
Message-ID: <20161115101856.GB4244@kroah.com> (raw)
In-Reply-To: <1479203739-3806-1-git-send-email-opensource.ganesh@gmail.com>

On Tue, Nov 15, 2016 at 05:55:39PM +0800, Ganesh Mahendran wrote:
> VM_IOREMAP is used to access hardware through a mechanism called
> I/O mapped memory. Android binder is a IPC machanism which will
> not access I/O memory.
> 
> Also VM_IOREMAP has alignment requiement which may not needed in
> binder.
>     __get_vm_area_node()
>     {
>     ...
>         if (flags & VM_IOREMAP)
>             align = 1ul << clamp_t(int, fls_long(size),
>                PAGE_SHIFT, IOREMAP_MAX_ORDER);
>     ...
>     }
> 
> This patch use VM_ALLOC to get vm area.
> 
> Below is the throughput test result:
> 
>   # ./binderThroughputTest -w 100
>   I run this command 10 times:
>                                before    after
>   average iterations per sec:  11199.9   11886.9
> 
> No performance regression found throgh binder test.
> 
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> ---
>  drivers/android/binder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What changed from v1?

Always list that below the --- line.

thanks,

greg k-h

  reply	other threads:[~2016-11-15 10:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15  9:55 [V2] android: binder: use VM_ALLOC to get vm area Ganesh Mahendran
2016-11-15 10:18 ` Greg KH [this message]
2016-11-15 13:18   ` Ganesh Mahendran
2017-02-09  9:54     ` Ganesh Mahendran
2017-02-09 10:17       ` Greg KH
2017-02-09 10:30         ` Ganesh Mahendran
2017-02-09 10:55           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161115101856.GB4244@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=opensource.ganesh@gmail.com \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox