From: Steven Rostedt <rostedt@goodmis.org>
To: Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
mingo@redhat.com, Mike Leach <mike.leach@arm.com>,
Tor Jeremiassen <tor@ti.com>,
philippe.langlais@st.com, Nicolas GUION <nicolas.guion@st.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Lyra Zhang <zhang.lyra@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V7 1/3] tracing: add a possibility of exporting function trace to other places instead of ring buffer only
Date: Tue, 15 Nov 2016 10:23:42 -0500 [thread overview]
Message-ID: <20161115102342.7ad27130@gandalf.local.home> (raw)
In-Reply-To: <CAG2=9p-2ZU3Zk0musHcwAEk4nM6RR0U7JhgyjZ+zjLaVLwz1ig@mail.gmail.com>
On Tue, 15 Nov 2016 16:14:29 +0800
Chunyan Zhang <zhang.chunyan@linaro.org> wrote:
>
> > Then why have a
> >
> > if (export->write)
> >
> >
> > Is there every going to be a case where export will not have a write
> > function?
>
> There shouldn't be.
>
> I can move this if statement to the register_ftrace_export() to ensure
> users won't wrongly use it, that's saying the write() of trace_export
> has been set before being registered to 'ftrace_exports_list'.
>
Looks like it's already there:
+int register_ftrace_export(struct trace_export *export)
+{
+ if (WARN_ON_ONCE(!export->write))
+ return -1;
-- Steve
next prev parent reply other threads:[~2016-11-15 15:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 8:08 [PATCH V7 0/3] Integration of function trace with System Trace IP blocks Chunyan Zhang
2016-10-18 8:08 ` [PATCH V7 1/3] tracing: add a possibility of exporting function trace to other places instead of ring buffer only Chunyan Zhang
2016-10-18 15:44 ` Steven Rostedt
2016-10-21 12:13 ` Chunyan Zhang
2016-11-14 2:06 ` Chunyan Zhang
2016-11-14 15:59 ` Steven Rostedt
2016-11-15 8:14 ` Chunyan Zhang
2016-11-15 15:23 ` Steven Rostedt [this message]
2016-10-18 8:08 ` [PATCH V7 2/3] stm class: ftrace: Add ftrace-export-over-stm driver Chunyan Zhang
2016-10-18 16:29 ` Steven Rostedt
2016-10-21 12:13 ` Chunyan Zhang
2016-10-18 8:09 ` [PATCH V7 3/3] stm: Mark the functions of writing buffer with notrace Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115102342.7ad27130@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@arm.com \
--cc=mingo@redhat.com \
--cc=nicolas.guion@st.com \
--cc=philippe.langlais@st.com \
--cc=tor@ti.com \
--cc=zhang.chunyan@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).