* [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block
@ 2016-11-15 13:24 Rahul Krishnan
2016-11-15 13:26 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Rahul Krishnan @ 2016-11-15 13:24 UTC (permalink / raw)
To: rmfrfs; +Cc: elder, johan, gregkh, devel, linux-kernel
This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
---
drivers/staging/greybus/sdio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index 5649ef1..f60b458 100644
--- a/drivers/staging/greybus/sdio.c
+++ b/drivers/staging/greybus/sdio.c
@@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
state_changed = 1;
}
- if (event & GB_SDIO_WP) {
- host->read_only = true;
- }
+ if (event & GB_SDIO_WP)
+ host->read_only = true;
if (state_changed) {
dev_info(mmc_dev(host->mmc), "card %s now event\n",
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block
2016-11-15 13:24 [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block Rahul Krishnan
@ 2016-11-15 13:26 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2016-11-15 13:26 UTC (permalink / raw)
To: Rahul Krishnan; +Cc: rmfrfs, devel, gregkh, johan, linux-kernel
On Tue, Nov 15, 2016 at 06:54:33PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
> ---
> drivers/staging/greybus/sdio.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index 5649ef1..f60b458 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
> state_changed = 1;
> }
>
> - if (event & GB_SDIO_WP) {
> - host->read_only = true;
> - }
> + if (event & GB_SDIO_WP)
> + host->read_only = true;
The indenting is messed up.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block
@ 2016-11-18 15:15 Rahul Krishnan
2016-11-18 15:30 ` Rui Miguel Silva
2016-11-21 4:08 ` Viresh Kumar
0 siblings, 2 replies; 5+ messages in thread
From: Rahul Krishnan @ 2016-11-18 15:15 UTC (permalink / raw)
To: rmfrfs; +Cc: elder, johan, gregkh, devel, linux-kernel
This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
---
drivers/staging/greybus/sdio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index 5649ef1..66b37ea 100644
--- a/drivers/staging/greybus/sdio.c
+++ b/drivers/staging/greybus/sdio.c
@@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
state_changed = 1;
}
- if (event & GB_SDIO_WP) {
+ if (event & GB_SDIO_WP)
host->read_only = true;
- }
if (state_changed) {
dev_info(mmc_dev(host->mmc), "card %s now event\n",
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block
2016-11-18 15:15 Rahul Krishnan
@ 2016-11-18 15:30 ` Rui Miguel Silva
2016-11-21 4:08 ` Viresh Kumar
1 sibling, 0 replies; 5+ messages in thread
From: Rui Miguel Silva @ 2016-11-18 15:30 UTC (permalink / raw)
To: Rahul Krishnan; +Cc: elder, johan, gregkh, devel, linux-kernel
Hi Rahul,
Thanks for the patch.
Now looks great.
On Fri, Nov 18, 2016 at 08:45:25PM +0530, Rahul Krishnan wrote:
>This patch fixes the following checkpath.pl warning
>WARNING: braces {} are not necessary for single statement blocks
>
>
>Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
>---
> drivers/staging/greybus/sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
>index 5649ef1..66b37ea 100644
>--- a/drivers/staging/greybus/sdio.c
>+++ b/drivers/staging/greybus/sdio.c
>@@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
> state_changed = 1;
> }
>
>- if (event & GB_SDIO_WP) {
>+ if (event & GB_SDIO_WP)
> host->read_only = true;
>- }
>
> if (state_changed) {
> dev_info(mmc_dev(host->mmc), "card %s now event\n",
>--
>2.10.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block
2016-11-18 15:15 Rahul Krishnan
2016-11-18 15:30 ` Rui Miguel Silva
@ 2016-11-21 4:08 ` Viresh Kumar
1 sibling, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2016-11-21 4:08 UTC (permalink / raw)
To: Rahul Krishnan
Cc: Rui Silva, driver-dev, Greg Kroah-Hartman, Johan Hovold,
linux-kernel@vger.kernel.org
On Fri, Nov 18, 2016 at 8:45 PM, Rahul Krishnan
<mrahul.krishnan@gmail.com> wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
>
>
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
> ---
> drivers/staging/greybus/sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-21 4:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-15 13:24 [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block Rahul Krishnan
2016-11-15 13:26 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2016-11-18 15:15 Rahul Krishnan
2016-11-18 15:30 ` Rui Miguel Silva
2016-11-21 4:08 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).