linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rahul Krishnan <mrahul.krishnan@gmail.com>
Cc: rmfrfs@gmail.com, devel@driverdev.osuosl.org,
	gregkh@linuxfoundation.org, johan@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block
Date: Tue, 15 Nov 2016 16:26:27 +0300	[thread overview]
Message-ID: <20161115132627.GR28701@mwanda> (raw)
In-Reply-To: <20161115132433.GA4534@rahul>

On Tue, Nov 15, 2016 at 06:54:33PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
> 
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
> ---
>  drivers/staging/greybus/sdio.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index 5649ef1..f60b458 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
>  		state_changed = 1;
>  	}
>  
> -	if (event & GB_SDIO_WP) {
> -		host->read_only = true;
> -	}
> +	if (event & GB_SDIO_WP)
> +	host->read_only = true;

The indenting is messed up.

regards,
dan carpenter

  reply	other threads:[~2016-11-15 13:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 13:24 [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block Rahul Krishnan
2016-11-15 13:26 ` Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-11-18 15:15 Rahul Krishnan
2016-11-18 15:30 ` Rui Miguel Silva
2016-11-21  4:08 ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161115132627.GR28701@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrahul.krishnan@gmail.com \
    --cc=rmfrfs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).