From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935057AbcKOGcy (ORCPT <rfc822;w@1wt.eu>);
        Tue, 15 Nov 2016 01:32:54 -0500
Received: from mail.kernel.org ([198.145.29.136]:38182 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755204AbcKOGcv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 15 Nov 2016 01:32:51 -0500
Date: Tue, 15 Nov 2016 15:32:39 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Shuah Khan <shuahkhan@gmail.com>, Shuah Khan <shuah@kernel.org>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Tom Zanussi <tom.zanussi@linux.intel.com>,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH -tip v2 2/6] selftests: ftrace: Initialize ftrace before
 each test
Message-Id: <20161115153239.7bf8958d61259bf9e5706c5e@kernel.org>
In-Reply-To: <20161114131200.7aaaaa13@gandalf.local.home>
References: <147781042852.11952.2843145560116738189.stgit@devbox>
        <147781045018.11952.9286420015716639736.stgit@devbox>
        <20161114131200.7aaaaa13@gandalf.local.home>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 14 Nov 2016 13:12:00 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sun, 30 Oct 2016 15:54:10 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > Reset ftrace to initial state before running each test.
> > This fixes some test cases to enable tracing before starting
> > trace test. This can avoid false-positive failure when
> > previous testcase fails while disabling tracing.
> > 
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> > ---
> >  tools/testing/selftests/ftrace/ftracetest       |    2 +-
> >  tools/testing/selftests/ftrace/test.d/functions |   25 +++++++++++++++++++++++
> >  2 files changed, 26 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> > index 4c6a0bf..a03d366 100755
> > --- a/tools/testing/selftests/ftrace/ftracetest
> > +++ b/tools/testing/selftests/ftrace/ftracetest
> > @@ -228,7 +228,7 @@ trap 'SIG_RESULT=$XFAIL' $SIG_XFAIL
> >  
> >  __run_test() { # testfile
> >    # setup PID and PPID, $$ is not updated.
> > -  (cd $TRACING_DIR; read PID _ < /proc/self/stat ; set -e; set -x; . $1)
> > +  (cd $TRACING_DIR; read PID _ < /proc/self/stat; set -e; set -x; initialize_ftrace; . $1)
> >    [ $? -ne 0 ] && kill -s $SIG_FAIL $SIG_PID
> >  }
> >  
> > diff --git a/tools/testing/selftests/ftrace/test.d/functions b/tools/testing/selftests/ftrace/test.d/functions
> > index c37262f..fbaf565 100644
> > --- a/tools/testing/selftests/ftrace/test.d/functions
> > +++ b/tools/testing/selftests/ftrace/test.d/functions
> > @@ -23,3 +23,28 @@ reset_trigger() { # reset all current setting triggers
> >      done
> >  }
> >  
> > +reset_events_filter() { # reset all current setting filters
> > +    grep -v ^none events/*/*/filter |
> > +    while read line; do
> > +	echo 0 > `echo $line | cut -f1 -d:`
> > +    done
> > +}
> > +
> > +disable_events() {
> > +    echo 0 > events/enable
> > +}
> > +
> > +initialize_ftrace() { # Reset ftrace to initial-state
> > +# As the initial state, ftrace will be set to nop tracer,
> > +# no events, no triggers, no filters, no function filters,
> > +# no probes, and tracing on.
> > +    disable_tracing
> > +    reset_tracer
> > +    reset_trigger
> > +    reset_events_filter
> > +    disable_events
> > +    echo | tee set_ftrace_* set_graph_* stack_trace_filter set_event_pid
> 
> I just disabled function graph tracing, and this causes every test to
> fail.
> 
>    tee: set_graph_*: Permission denied

Oops, right. OK, I'll fix that.

Thanks!

> 
> -- Steve
> 
> > +    echo > kprobe_events
> > +    echo > uprobe_events
> > +    enable_tracing
> > +}
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>