From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934199AbcKOSZi (ORCPT ); Tue, 15 Nov 2016 13:25:38 -0500 Received: from mail-pg0-f49.google.com ([74.125.83.49]:33102 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbcKOSZg (ORCPT ); Tue, 15 Nov 2016 13:25:36 -0500 X-Greylist: delayed 353 seconds by postgrey-1.27 at vger.kernel.org; Tue, 15 Nov 2016 13:25:36 EST Date: Tue, 15 Nov 2016 10:19:39 -0800 From: Eric Biggers To: Richard Weinberger Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, dedekind1@gmail.com, adrian.hunter@intel.com, tytso@mit.edu, jaegeuk@kernel.org, david@sigma-star.at, wd@denx.de, sbabic@denx.de, dengler@linutronix.de, mhalcrow@google.com, hch@infradead.org Subject: Re: [PATCH 02/29] fscrypt: Allow fscrypt_decrypt_page() to function with non-writeback pages Message-ID: <20161115181939.GB127180@google.com> References: <1479072072-6844-1-git-send-email-richard@nod.at> <1479072072-6844-3-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479072072-6844-3-git-send-email-richard@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 13, 2016 at 10:20:45PM +0100, Richard Weinberger wrote: > /** > * f2crypt_decrypt_page() - Decrypts a page in-place > - * @page: The page to decrypt. Must be locked. > + * @inode: The encrypted inode to decrypt. > + * @page: The page to decrypt. Must be locked. Strictly speaking, it's not the inode itself being decrypted, but rather the data associated with it. Could this be better expressed as something like "The inode to which the page belongs"? Eric