From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754289AbcKQE1L (ORCPT ); Wed, 16 Nov 2016 23:27:11 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:33072 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753211AbcKQE1J (ORCPT ); Wed, 16 Nov 2016 23:27:09 -0500 Date: Wed, 16 Nov 2016 23:27:07 -0500 (EST) Message-Id: <20161116.232707.1586517242816228983.davem@davemloft.net> To: Julia.Lawall@lip6.fr Cc: w-kwok2@ti.com, kernel-janitors@vger.kernel.org, m-karicheri2@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, christophe.jaillet@wanadoo.fr Subject: Re: [PATCH 1/2] net: netcp: replace IS_ERR_OR_NULL by IS_ERR From: David Miller In-Reply-To: <1479293014-18811-2-git-send-email-Julia.Lawall@lip6.fr> References: <1479293014-18811-1-git-send-email-Julia.Lawall@lip6.fr> <1479293014-18811-2-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Nov 2016 19:27:40 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall Date: Wed, 16 Nov 2016 11:43:33 +0100 > knav_queue_open always returns an ERR_PTR value, never NULL. This can be > confirmed by unfolding the function calls and conforms to the function's > documentation. Thus, replace IS_ERR_OR_NULL by IS_ERR in error checks. > > The change is made using the following semantic patch: > (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall Applied to net-next, thanks.